[Due for payment 2025-03-05] [$250] Room - Room mention turns into a random number after leaving a private room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+2850@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Create a private room
4. Go to the workspace chat and mention the room
5. Navigate to the room by tapping on the room mention
6. Leave from the private room

Expected Result:

The room mention stays displaying the room name

Actual Result:

The room mention changes to show a random number

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6722182_1737667139938.XRecorder_24012025_001119.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021885423124058262616
• Upwork Job ID: 1885423124058262616
• Last Price Increase: 2025-02-14
• Automatic offers:
• paultsimura | Reviewer | 106196319
• daledah | Contributor | 106196323

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-23 23:06:35 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The room mention changes to show a random number

What is the root cause of that problem?

When leaving room, we set the reportName to null:

App/src/libs/actions/Report.ts

Lines 3106 to 3107 in d930fea

	: Object.keys(report).reduce<Record<string, null>>((acc, key) => {
	acc[key] = null;

so we display the reportID:

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 37 in d930fea

mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? htmlAttributeReportID);

What changes do you think we should make in order to solve the problem?

We shouldn't set the reportName to null in:

App/src/libs/actions/Report.ts

Line 3107 in d930fea

acc[key] = null;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should mock the room data and then simulate the leaving room action. Then verify whether its name still exists.

What alternative solutions did you explore? (Optional)

In:

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 37 in d930fea

mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? htmlAttributeReportID);

pass the reportAction data:

    const mentionReportContextValue = useMemo(() => ({currentReportID: report?.reportID ?? '-1', reportAction: action}), [report?.reportID, action]);

In:

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 59 in d930fea

const {currentReportID: currentReportIDContext, exactlyMatch} = useContext(MentionReportContext);

we get the reportAction data.

In:

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 70 in d930fea

const mentionDetails = getMentionDetails(htmlAttributeReportID, currentReport, reports, tnode);

pass the reportAction as the 5th param.

In:

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 29 in d930fea

const getMentionDetails = (htmlAttributeReportID: string, currentReport: OnyxEntry<Report>, reports: OnyxCollection<Report>, tnode: TText | TPhrasing) => {

update the function so that it can receive 5th param.

Finally, update:

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 37 in d930fea

mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? htmlAttributeReportID);

        mentionDisplayText = removeLeadingLTRAndHash(report?.reportName ?? getReportActionMessageText(reportAction) ?? htmlAttributeReportID);

[melvin-bot]

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@abekkala Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@abekkala 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021885423124058262616

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[paultsimura]

Reviewing soon 👀

[paultsimura]

Thanks @daledah, unfortunately, your solution works optimistically until the first chat reload:

Screen.Recording.2025-02-03.at.22.13.18.mov

[dylanexpensify]

@daledah are you working on an updated solution?

[paultsimura]

@daledah are you working on an updated solution?

The deeper issue seems to be a BE one, so we might want to combine @daledah's proposal and a BE fix.

@daledah could you please investigate it closer?

[daledah]

Thanks @daledah, unfortunately, your solution works optimistically until the first chat reload:

When reloading the app, it calls ReconnectApp API, which will set the room data to null. As a result, the reportName field is gone, so the bug exists again.

Solution: It is a BE issue, so we need to make sure the ReconnectApp API didn't set the room data to null.

[melvin-bot]

@abekkala @paultsimura this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[paultsimura]

Thanks @daledah. Let's bring an Engineer in and see where we stand after the BE is fixed. If the issue remains, we'll proceed with your FE proposal.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[daledah]

Let's bring an Engineer in and see where we stand after the BE is fixed. If the issue remains, we'll proceed with your FE proposal.

@paultsimura @aldo-expensify This issue requires fixes on both the FE and BE sides:

• The FE fix has already been outlined in my proposal.

• The BE fix is detailed in this comment.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aldo-expensify]

I can take care of the backend changes, I just need some time to understand what these changes imply and how to do them. I may have time close to the end of the week to work on this.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[aldo-expensify]

This needs a fix in both backend layers:

• https://github.com/Expensify/Web-Expensify/pull/45521
• https://github.com/Expensify/Auth/pull/14188

I'll have to finish it on Tuesday

[melvin-bot]

@abekkala, @paultsimura, @aldo-expensify Eep! 4 days overdue now. Issues have feelings too...

[aldo-expensify]

Still working on the backend

[aldo-expensify]

From testing with the UI, these App changes seem to work well for me:

    const successData: OnyxUpdate[] = [];
    if (isWorkspaceMemberLeavingWorkspaceRoom || isChatThread) {
        successData.push({
            onyxMethod: Onyx.METHOD.MERGE,
            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
            value: {
                participants: {
                    [currentUserAccountID]: {
                        notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
                    },
                },
            }
        });
    } else {
        successData.push({
            onyxMethod: Onyx.METHOD.SET,
            key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
            value: {reportName: report.reportName}
        });
    }

(Inspired from the proposed solution by @daledah here: #55676 (comment))

[aldo-expensify]

I'll make the backend PRs ready for review asap (today)

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[aldo-expensify]

Hiring @daledah for the frontend changes

[aldo-expensify]

Made backend PR's ready for review

[daledah]

@paultsimura FE PR is ready. Waiting for BE change to test ReconnectApp behavior.

[aldo-expensify]

The backend PRs were merged but are waiting for deploy, they will be deployed on monday.

[aldo-expensify]

all the backend changes were deployed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: keep private room name when leaving #57193

If no regressions arise, payment will be issued on 2025-03-05. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Reviewer)
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@paultsimura @abekkala @paultsimura The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]