Code

feat: add/remove reaction#15210

Code

Merged

stitesExpensify merged 74 commits intoExpensify:mainExpensify/App:mainfrom margelo:hanno/feat-add-remove-reactionsmargelo/expensify-app-fork:hanno/feat-add-remove-reactionsCopy head branch name to clipboardMar 8, 2023

+1,327-62

Commits

Commits on Feb 15, 2023

• wip: render quick reactions in context menu

  hannojg

  committed
  80333cb

• wip: adjustments for web

  hannojg

  committed
  071b88f

• add actions for adding and removing reactions

  hannojg

  committed
  a984a0b

• wip: add reaction when using quick reactions

  hannojg

  committed
  f96b73b

• render emoji reactions underneath a message

  hannojg

  committed
  a164fa1

• TEMP: REMOVE ME once accountID on personal details is live

  hannojg

  committed
  f0926c1

• change from login to accountID

  hannojg

  committed
  318931f

• wip: adding / removing

  hannojg

  committed
  549bcbe

Commits on Feb 16, 2023

• change: when removing reactions, remove the whole emoji object

  hannojg

  committed
  c7de8cd

• cleanup code

  hannojg

  committed
  7281f82

• show AddReactionBubble in the row of reactions as well

  hannojg

  committed
  7907fd2

• implemented toggling reactions when selecting the same again

  hannojg

  committed
  71220c0

• close context menu when open emoji picker or selected emoji

  hannojg

  committed
  44909ab

• fix emoji picker being wrong positioned

  hannojg

  committed
  8042b9b

• wip: mini menu

  hannojg

  committed
  483b119

• wip: mini menu adding add reaction icon

  hannojg

  committed
  20d463c

• fix: mini menu open picker wrong positioned + was closing

  hannojg

  committed
  99bfb91

• Merge branch 'main' of github.com:margelo/expensify-app-fork into hanno/feat-add-remove-reactions

  hannojg

  committed
  2f61782

Commits on Feb 17, 2023

• fix: open emoji picker on mobile

  hannojg

  committed
  85357b1

• clean up

  hannojg

  committed
  4c07ba2

Commits on Feb 19, 2023

• rename and document functions

  hannojg

  committed
  e064297

• pick the preferred skin tone

  hannojg

  committed
  52a9135

• updated JSDocs

  hannojg

  committed
  c8c450c

• updated JSDocs

  hannojg

  committed
  bf7d78e

• updated JSDocs

  hannojg

  committed
  f874ea5

• remove todos

  hannojg

  committed
  267338e

• apply suggestions from design doc

  hannojg

  committed
  b09e44d

• apply suggestions from design doc

  hannojg

  committed
  1b8041f

• Merge branch 'main' of github.com:margelo/expensify-app-fork into hanno/feat-add-remove-reactions

  hannojg

  committed
  33c0554

• fix tests

  hannojg

  committed
  8675022

Commits on Feb 20, 2023

• fix: pas emoji object directly

  hannojg

  committed
  57082d6

• refactor: pass ref optional as arg

  hannojg

  committed
  28f80d3

• fix: pass anchor position for emoji picker as well to fix issue with positioning

  hannojg

  committed
  ba6970e

• apply suggestions from code review

  hannojg

  committed
  f2e407c

Commits on Feb 28, 2023

• Merge branch 'main' of github.com:margelo/expensify-app-fork into hanno/feat-add-remove-reactions

  hannojg

  committed
  97c8d08

• enable API calls

  hannojg

  committed
  3b24a03

Commits on Mar 4, 2023

• Merge branch 'main' of github.com:margelo/expensify-app-fork into hanno/feat-add-remove-reactions

  hannojg

  committed
  f4c94d8

Commits on Mar 5, 2023

• fix issue where reactions won't re-render

  hannojg

  committed
  8bc100b

• temp fix toggling reactions is broken

  hannojg

  committed
  e9ba4f5

• fix removing reactions causing artefacts

  hannojg

  committed
  55834f6

• fix regression where mini menu items weren't displaying correctly

  hannojg

  committed
  1cb6d60

• fix: don't remove reactions when editing a message

  Show description for 516ef3a
  hannojg

  committed
  516ef3a

Commits on Mar 6, 2023

• expose hasAccountIDReacted

  hannojg

  committed
  adb6e7d

• apply code suggestion

  hannojg

  committed
  debe8ad

• Update src/libs/actions/Report.js

  Show description for 8ed9e99
  

  hannojg

  and

  stitesExpensify

  authored
  8ed9e99

• apply code suggestion

  hannojg

  committed
  d8fa085

• apply code suggestion

  hannojg

  committed
  da0e536

• apply code suggestion

  hannojg

  committed
  5b2c512

• apply code suggestion

  hannojg

  committed
  5842cf7

• remove unnecessary requestLayoutAnimation

  hannojg

  committed
  952fe98

• added translations

  hannojg

  committed
  dd48b96

• match text

  hannojg

  committed
  c7c3411

• reflect preferred skin tone in the rest of the UI

  hannojg

  committed
  db1026a

• fixed bug where mini context menu wouldn't close

  hannojg

  committed
  5e7e7c1

• fix: make emojis in quick reaction unselectable

  hannojg

  committed
  b73de4b

• fix: immediately remove reaction bar when no reactions are present anymore

  hannojg

  committed
  5db0b1f

• fix tests

  hannojg

  committed
  231fb63

• Merge branch 'main' of github.com:margelo/expensify-app-fork into hanno/feat-add-remove-reactions

  hannojg

  committed
  96d55ae

• fix warning

  hannojg

  committed
  662c8ef

• suppress eslint warning

  hannojg

  committed
  f45dfeb

• remove unused default props

  hannojg

  committed
  91dc75f

• remove focusable prop as not needed on web

  hannojg

  committed
  5a62b43

• add tooltip

  hannojg

  committed
  1e5c971

• fix key issue

  hannojg

  committed
  cd93903

Commits on Mar 7, 2023

• fix focusable prop

  hannojg

  committed
  6520062

• rename to openContextMenu and shouldKeepOpen

  hannojg

  committed
  d63a77b

• Revert "TEMP: REMOVE ME once accountID on personal details is live"

  Show description for e332259
  hannojg

  committed
  e332259

• add container styles back

  hannojg

  committed
  effd5f4

• Merge branch 'main' of github.com:margelo/expensify-app-fork into hanno/feat-add-remove-reactions

  hannojg

  committed
  840e381

• skip reactions for IOU messages for now

  Show description for dd5b07c
  hannojg

  committed
  dd5b07c

Commits on Mar 8, 2023

• fix focus on AddReactionBubble

  hannojg

  committed
  7af1573

• fix safari selection bug

  hannojg

  committed
  baa93cc

• fix adding multiple times the same reaction

  hannojg

  committed
  9b8e1ac

• check specifically for undefined

  hannojg

  committed
  9e3596f