Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected confirm task button bottom margin #18843

Merged
merged 1 commit into from
May 17, 2023
Merged

Corrected confirm task button bottom margin #18843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/tasks/NewTaskPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ const NewTaskPage = (props) => {
}

return (
<ScreenWrapper includeSafeAreaPaddingBottom={false}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgolen @thienlnam @fedirjh is there any particular reason it was built like that in #17992, that we are missing and for which we should not make this bug fix?

Additionally, should we also make this change in other places where it was done like that in that particular PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe so, I think it was just a styling thing that was copied from another file

Copy link
Contributor

@flodnv flodnv May 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't believe what? that there is something we are missing and for which we should not make this bug fix? that we should also make this change in other places where it was done like that in that particular PR? both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that there is any particular reason it was built like that. We should also make this same change on other task pages if it hasn't already been done (Assignee, Description, Title Pages)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do that please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19240

<ScreenWrapper>
<HeaderWithCloseButton
title={props.translate('newTaskPage.confirmTask')}
onCloseButtonPress={() => Navigation.dismissModal()}
Expand Down