From cbb01464bd076cd62b7dfd919eb49c337be624ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ska=C5=82ka?= Date: Thu, 1 Jun 2023 16:28:49 +0200 Subject: [PATCH 1/3] migrated HeaderView to PressableWithoutFeedback --- src/pages/home/HeaderView.js | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/src/pages/home/HeaderView.js b/src/pages/home/HeaderView.js index 2d9d4cd4f265..c011928e2b35 100644 --- a/src/pages/home/HeaderView.js +++ b/src/pages/home/HeaderView.js @@ -1,6 +1,6 @@ import _ from 'underscore'; import React from 'react'; -import {View, Pressable} from 'react-native'; +import {View} from 'react-native'; import PropTypes from 'prop-types'; import lodashGet from 'lodash/get'; import {withOnyx} from 'react-native-onyx'; @@ -29,6 +29,7 @@ import ThreeDotsMenu from '../../components/ThreeDotsMenu'; import * as Task from '../../libs/actions/Task'; import reportActionPropTypes from './report/reportActionPropTypes'; import * as Session from '../../libs/actions/Session'; +import PressableWithoutFeedback from '../../components/Pressable/PressableWithoutFeedback'; const propTypes = { /** Toggles the navigationMenu open and closed */ @@ -127,10 +128,12 @@ const HeaderView = (props) => { > {props.isSmallScreenWidth && ( - { - + )} {Boolean(props.report && title) && ( - ReportUtils.navigateToDetailsPage(props.report)} style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]} disabled={isTaskReport} + accessibilityLabel={title} + accessibilityRole="button" > {shouldShowSubscript ? ( { /> )} - + {shouldShowCallButton && ( { /> )} - Report.togglePinnedState(props.report))} style={[styles.touchableButtonImage]} + accessibilityLabel={props.translate('common.pin')} + accessibilityState={{ + checked: props.report.isPinned, + }} + accessibilityRole="togglebutton" > - + {shouldShowThreeDotsButton && ( Date: Mon, 5 Jun 2023 09:42:31 +0200 Subject: [PATCH 2/3] removed Podfile.lock changes --- ios/Podfile.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ios/Podfile.lock b/ios/Podfile.lock index ae913bda8338..6cb4235c58c8 100644 --- a/ios/Podfile.lock +++ b/ios/Podfile.lock @@ -1019,7 +1019,7 @@ EXTERNAL SOURCES: SPEC CHECKSUMS: Airship: c70eed50e429f97f5adb285423c7291fb7a032ae AirshipFrameworkProxy: 7bc4130c668c6c98e2d4c60fe4c9eb61a999be99 - boost: 57d2868c099736d80fcd648bf211b4431e51a558 + boost: a7c83b31436843459a1961bfd74b96033dc77234 CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 FBLazyVector: ff54429f0110d3c722630a98096ba689c39f6d5f @@ -1062,7 +1062,7 @@ SPEC CHECKSUMS: Permission-LocationWhenInUse: 3ba99e45c852763f730eabecec2870c2382b7bd4 Plaid: 7d340abeadb46c7aa1a91f896c5b22395a31fcf2 PromisesObjC: 09985d6d70fbe7878040aa746d78236e6946d2ef - RCT-Folly: 424b8c9a7a0b9ab2886ffe9c3b041ef628fd4fb1 + RCT-Folly: 0080d0a6ebf2577475bda044aa59e2ca1f909cda RCTRequired: e9e7b8b45aa9bedb2fdad71740adf07a7265b9be RCTTypeSafety: 9ae0e9206625e995f0df4d5b9ddc94411929fb30 React: a71c8e1380f07e01de721ccd52bcf9c03e81867d @@ -1135,4 +1135,4 @@ SPEC CHECKSUMS: PODFILE CHECKSUM: 4ed1c7b099741c82e2b0411b95f6468e72be6c76 -COCOAPODS: 1.12.1 +COCOAPODS: 1.12.0 From 6a87e42db725593aa6db4b844985a967f7a490e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Ska=C5=82ka?= Date: Mon, 12 Jun 2023 10:13:14 +0200 Subject: [PATCH 3/3] fixed failing job3 --- .../Pressable/GenericPressable/BaseGenericPressable.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/Pressable/GenericPressable/BaseGenericPressable.js b/src/components/Pressable/GenericPressable/BaseGenericPressable.js index 0b15378de8bc..066e14989930 100644 --- a/src/components/Pressable/GenericPressable/BaseGenericPressable.js +++ b/src/components/Pressable/GenericPressable/BaseGenericPressable.js @@ -35,7 +35,6 @@ const GenericPressable = forwardRef((props, ref) => { onKeyPress, disabled, style, - accessibilityHint, shouldUseHapticsOnLongPress, shouldUseHapticsOnPress, nextFocusRef,