Fix split bill display / selection with new users #21113

Beamanator · 2023-06-20T12:40:22Z

Details

Fixed Issues

$ #21075

Tests

Create a new group with multiple new users that you have not chatted before
Click on + in the group and select split bill
Enter amount and click on save/continue
On the split money page, notice there are multiple users in green checkmark selected. (expected)
Select each split user & make sure the correct user gets deselected (only the one you click)
Click around to make sure the correct split user always gets selected / unselected
Verify you still can't click on your own user (shown at the top) since you're the one splitting the bill
Verify finishing the request / splitting the bill works as it does in Staging as well
Do the same steps as above, but with accounts that already exist
Verify everything still works as expected

Verify that no errors appear in the JS console

Offline tests

Verify the above still works offline - all the correct personal details are shown everywhere

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-06-20T12:40:27Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-06-20T12:42:33Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

src/libs/OptionsListUtils.js

s77rt · 2023-06-20T12:57:47Z

src/libs/OptionsListUtils.js

-        keyForList: details.login,
-        login: details.login,
+        keyForList: details.login || details.displayName || String(details.accountID),
+        login: details.login || details.displayName,


Hmm, why we fallback to displayName in login? This is confusing

The user's login is not always going to be available in details - so we either need to default to displayName here orrr store displayName in each option and default to it when we render these options, right?

What would go wrong if we keep the login field empty/undefined? (instead of falling back to displayName)

This is what I was fixing - if there's no login we get this

ah I see, can we instead set a displayName field and use it in the iou pages

Relaying on accountID instead of login seems to do it.

const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips( (this.props.option.participantsList || this.props.option.accountID ? [this.props.option] : []).slice(0, 10), isMultipleParticipant, );

Ooh that seems like a better fix - though I'm still surprised isMoneyRequestReport: true, on options for MoneyRequest pages... Maybe that's a follow-up question

I will be back in 45min or so, the above fix should be the correct fix, feel free to merge if this is critical

isMoneyRequestReport is unrelated. this is true when the report is iou report or expense report, this has nothing to do with iou, it's used for other optionrow usage (not totally sure, but that's what I think)

asking in slack for someone to test on all platforms for you

Beamanator · 2023-06-20T14:01:25Z

src/libs/OptionsListUtils.js

@@ -216,18 +216,19 @@ function isPersonalDetailsReady(personalDetails) {
 function getParticipantsOptions(report, personalDetails) {


I'm curious why we're not returning isMoneyRequestReport: true here, but that's for another day

Asked here, but it's been a few months so idk if there's a good answer, just checking

narefyev91 · 2023-06-20T15:01:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

8mb.video-9GW-lIjZ8WDH.mp4

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

8mb.video-hjk-MSNRJKZc.mp4

iOS

8mb.video-oze-cRTyiYcm.mp4

Android

8mb.video-OGn-DuSLl0FR.mp4

s77rt · 2023-06-20T15:04:15Z

Something still broken

Kooha-2023-06-20-15-59-43.mp4

s77rt · 2023-06-20T15:04:49Z

@narefyev91 You need to test against staging server (toggle on the staging switch)

s77rt · 2023-06-20T15:13:59Z

I think I found that bug. In BaseOptionList, OptionRow isSelected prop is based once again on login, let's change that to accountID.

App/src/components/OptionsList/BaseOptionsList.js

Line 171 in e6c2704

    
           isSelected={Boolean(_.find(this.props.selectedOptions, (option) => option.login === item.login))}

Beamanator · 2023-06-20T15:23:43Z

@s77rt interesting, I can't reproduce that even on staging at the moment 🤔 But I do think what you're looking at is another thing that should be fixed at some point so I might as well do it in this PR 😅

Beamanator · 2023-06-20T15:24:39Z

@s77rt can you please re-test with the updated change?

s77rt · 2023-06-20T15:26:26Z

Much better!

Fix split bill display / selection with new users (cherry picked from commit 574c73e)

…-21113 🍒 Cherry pick PR #21113 to staging 🍒

OSBotify · 2023-06-20T16:47:56Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.29-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Beamanator · 2023-06-20T17:37:58Z

Looks like it's working well on staging 👍

Screen.Recording.2023-06-20.at.8.35.36.PM.mov

OSBotify · 2023-06-21T02:16:55Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T22:17:40Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.32-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-26T20:48:17Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.32-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Beamanator added 3 commits June 20, 2023 15:35

Rename to make var more clear

cb4d866

Add appropriate defaults

badbbd0

Make var names clearer & use accountIDs more

98a739e

Beamanator requested a review from a team as a code owner June 20, 2023 12:40

Beamanator self-assigned this Jun 20, 2023

melvin-bot bot requested review from narefyev91 and removed request for a team June 20, 2023 12:40

Beamanator added the CP Staging label Jun 20, 2023

Beamanator mentioned this pull request Jun 20, 2023

[HOLD for payment 2023-06-29] Selecting/removing one user selects/removes all the user on split bill group page #21075

Closed

6 tasks

s77rt reviewed Jun 20, 2023

View reviewed changes

Beamanator removed the request for review from narefyev91 June 20, 2023 13:09

Beamanator added 4 commits June 20, 2023 16:10

accountID should always exist and be unique

b22d585

These are money request reports

45160f4

Remove thing we might add back

bcda417

Fix default option if accountID exists

1f09dde

Beamanator commented Jun 20, 2023

View reviewed changes

narefyev91 approved these changes Jun 20, 2023

View reviewed changes

melvin-bot bot requested a review from aldo-expensify June 20, 2023 15:01

Use accountIDs for matching selected options

e8644ea

s77rt approved these changes Jun 20, 2023

View reviewed changes

luacmartins approved these changes Jun 20, 2023

View reviewed changes

luacmartins merged commit 574c73e into main Jun 20, 2023

luacmartins deleted the beaman-fixSplitBillWithNewUsers branch June 20, 2023 15:37

Beamanator mentioned this pull request Jun 20, 2023

The "Hmm... it's not here" page is displayed when attempting to view a profile after splitting the bill. #20970

Closed

6 tasks

OSBotify pushed a commit that referenced this pull request Jun 20, 2023

Merge pull request #21113 from Expensify/beaman-fixSplitBillWithNewUsers

a10b11c

Fix split bill display / selection with new users (cherry picked from commit 574c73e)

OSBotify mentioned this pull request Jun 20, 2023

🍒 Cherry pick PR #21113 to staging 🍒 #21134

Merged

OSBotify added a commit that referenced this pull request Jun 20, 2023

Merge pull request #21134 from Expensify/OSBotify-cherry-pick-staging…

23f59d1

…-21113 🍒 Cherry pick PR #21113 to staging 🍒

OSBotify mentioned this pull request Jun 20, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

luacmartins mentioned this pull request Jun 20, 2023

Web - Split Bill - No details shown on split bill details page of a new user (only profile picture is shown) #20966

Closed

6 tasks

OSBotify mentioned this pull request Jun 21, 2023

Deploy Checklist: New Expensify 2023-06-21 #21172

Closed

67 tasks

OSBotify mentioned this pull request Jun 24, 2023

Deploy Checklist: New Expensify 2023-06-24 #21477

Closed

45 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix split bill display / selection with new users #21113

Fix split bill display / selection with new users #21113

Beamanator commented Jun 20, 2023 •

edited

Loading

melvin-bot bot commented Jun 20, 2023

github-actions bot commented Jun 20, 2023

s77rt Jun 20, 2023

Beamanator Jun 20, 2023

s77rt Jun 20, 2023

Beamanator Jun 20, 2023

s77rt Jun 20, 2023

s77rt Jun 20, 2023

Beamanator Jun 20, 2023

s77rt Jun 20, 2023

s77rt Jun 20, 2023

Beamanator Jun 20, 2023

Beamanator Jun 20, 2023

Beamanator Jun 20, 2023

narefyev91 commented Jun 20, 2023

s77rt commented Jun 20, 2023

s77rt commented Jun 20, 2023

s77rt commented Jun 20, 2023

Beamanator commented Jun 20, 2023

Beamanator commented Jun 20, 2023

s77rt commented Jun 20, 2023

OSBotify commented Jun 20, 2023

Beamanator commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 26, 2023

		@@ -216,18 +216,19 @@ function isPersonalDetailsReady(personalDetails) {
		function getParticipantsOptions(report, personalDetails) {

Fix split bill display / selection with new users #21113

Fix split bill display / selection with new users #21113

Conversation

Beamanator commented Jun 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 20, 2023

github-actions bot commented Jun 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

narefyev91 commented Jun 20, 2023

Reviewer Checklist

Screenshots/Videos

s77rt commented Jun 20, 2023

s77rt commented Jun 20, 2023

s77rt commented Jun 20, 2023

Beamanator commented Jun 20, 2023

Beamanator commented Jun 20, 2023

s77rt commented Jun 20, 2023

OSBotify commented Jun 20, 2023

Beamanator commented Jun 20, 2023

OSBotify commented Jun 21, 2023

OSBotify commented Jun 23, 2023

OSBotify commented Jun 26, 2023

Beamanator commented Jun 20, 2023 •

edited

Loading