From d1a65f0c0d818a4145300d628415faf2e06921f6 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Sat, 19 Aug 2023 11:43:03 +0800 Subject: [PATCH 1/4] fix storybook error --- .storybook/preview.js | 7 ++++++- src/components/MagicCodeInput.js | 2 +- src/stories/Composer.stories.js | 7 +++++-- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.storybook/preview.js b/.storybook/preview.js index 7ccfd74e0e45..ba5acc49da91 100644 --- a/.storybook/preview.js +++ b/.storybook/preview.js @@ -8,14 +8,19 @@ import HTMLEngineProvider from '../src/components/HTMLEngineProvider'; import OnyxProvider from '../src/components/OnyxProvider'; import {LocaleContextProvider} from '../src/components/withLocalize'; import ONYXKEYS from '../src/ONYXKEYS'; +import {KeyboardStateProvider} from '../src/components/withKeyboardState'; +import {EnvironmentProvider} from '../src/components/withEnvironment'; Onyx.init({ keys: ONYXKEYS, + initialKeyStates: { + [ONYXKEYS.NETWORK]: {isOffline: false}, + }, }); const decorators = [ (Story) => ( - + ), diff --git a/src/components/MagicCodeInput.js b/src/components/MagicCodeInput.js index 5dba1c9c1b20..be6f74aa5d72 100644 --- a/src/components/MagicCodeInput.js +++ b/src/components/MagicCodeInput.js @@ -51,7 +51,7 @@ const propTypes = { }; const defaultProps = { - value: undefined, + value: '', name: '', autoFocus: true, errorText: '', diff --git a/src/stories/Composer.stories.js b/src/stories/Composer.stories.js index 3dfc5b0e3ead..50039d7d537a 100644 --- a/src/stories/Composer.stories.js +++ b/src/stories/Composer.stories.js @@ -8,6 +8,9 @@ import styles from '../styles/styles'; import themeColors from '../styles/themes/default'; import * as StyleUtils from '../styles/StyleUtils'; import CONST from '../CONST'; +import withNavigationFallback from '../components/withNavigationFallback'; + +const ComposerWithNavigation = withNavigationFallback(Composer); /** * We use the Component Story Format for writing stories. Follow the docs here: @@ -16,7 +19,7 @@ import CONST from '../CONST'; */ const story = { title: 'Components/Composer', - component: Composer, + component: ComposerWithNavigation, }; const parser = new ExpensiMark(); @@ -29,7 +32,7 @@ function Default(args) { return ( - Date: Sat, 19 Aug 2023 12:00:11 +0800 Subject: [PATCH 2/4] fix storybook error --- .storybook/preview.js | 7 +++++-- src/stories/Checkbox.stories.js | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.storybook/preview.js b/.storybook/preview.js index ba5acc49da91..b198c0d2d626 100644 --- a/.storybook/preview.js +++ b/.storybook/preview.js @@ -7,9 +7,10 @@ import ComposeProviders from '../src/components/ComposeProviders'; import HTMLEngineProvider from '../src/components/HTMLEngineProvider'; import OnyxProvider from '../src/components/OnyxProvider'; import {LocaleContextProvider} from '../src/components/withLocalize'; -import ONYXKEYS from '../src/ONYXKEYS'; import {KeyboardStateProvider} from '../src/components/withKeyboardState'; import {EnvironmentProvider} from '../src/components/withEnvironment'; +import {WindowDimensionsProvider} from '../src/components/withWindowDimensions'; +import ONYXKEYS from '../src/ONYXKEYS'; Onyx.init({ keys: ONYXKEYS, @@ -20,7 +21,9 @@ Onyx.init({ const decorators = [ (Story) => ( - + ), diff --git a/src/stories/Checkbox.stories.js b/src/stories/Checkbox.stories.js index 7148281f2a7e..4a7de2c29753 100644 --- a/src/stories/Checkbox.stories.js +++ b/src/stories/Checkbox.stories.js @@ -22,6 +22,7 @@ const Default = Template.bind({}); Default.args = { onPress: () => {}, isChecked: true, + accessibilityLabel: '', }; export {Default}; From 4222e2b51b3d13c75064bdc5202616aa57fec153 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Wed, 23 Aug 2023 17:05:49 +0800 Subject: [PATCH 3/4] add a value state --- src/stories/MagicCodeInput.stories.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/stories/MagicCodeInput.stories.js b/src/stories/MagicCodeInput.stories.js index 7d5f26eb05d8..2d5d505bca46 100644 --- a/src/stories/MagicCodeInput.stories.js +++ b/src/stories/MagicCodeInput.stories.js @@ -1,4 +1,4 @@ -import React from 'react'; +import React, {useState} from 'react'; import MagicCodeInput from '../components/MagicCodeInput'; /** @@ -12,8 +12,15 @@ const story = { }; function Template(args) { + const [value, setValue] = useState(''); // eslint-disable-next-line react/jsx-props-no-spreading - return ; + return ( + + ); } // Arguments can be passed to the component by binding From 10d67209b158ed177d8e80e4543775dbfe4c653a Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Wed, 23 Aug 2023 17:10:05 +0800 Subject: [PATCH 4/4] fix lint --- src/stories/MagicCodeInput.stories.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stories/MagicCodeInput.stories.js b/src/stories/MagicCodeInput.stories.js index 2d5d505bca46..1ea746dd44ac 100644 --- a/src/stories/MagicCodeInput.stories.js +++ b/src/stories/MagicCodeInput.stories.js @@ -13,11 +13,11 @@ const story = { function Template(args) { const [value, setValue] = useState(''); - // eslint-disable-next-line react/jsx-props-no-spreading return ( );