Map panning fix (2) #26500

gegham-khachatryan · 2023-09-01T17:10:23Z

Details

Fixed Issues

$ #25732

PROPOSAL: #25732 (comment)

Tests

Click the "+" icon next to the chat message text field. Click "Request Money" on the pop up menu that appears.
Check "Distance" tab on the Right Hand Panel that appears
Click the "Start" item from the list of waypoints.
In the text field that appears in the next screen, type "88 Kearny Street". Click the first option "88 Kearny Street, San Francisco, CA, USA" that appears.
Map camera flied to selected address where marker is visible.
Click Add Step button
Click on new added step
In the text field that appears in the next screen, type "Golden Gate Park". Click the first option "Golden Gate Pkwy, Naples, FL, USA" that appears.
Verify that the 2 markers are on the map and camera moved to show both on the screen.
Added Finish step
Verify that the distance was drawn as expected.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Click the "+" icon next to the chat message text field. Click "Request Money" on the pop up menu that appears.
Check "Distance" tab on the Right Hand Panel that appears
Click the "Start" item from the list of waypoints.
In the text field that appears in the next screen, type "88 Kearny Street". Click the first option "88 Kearny Street, San Francisco, CA, USA" that appears.
Map camera flied to selected address where marker is visible.
Click Add Step button
Click on new added step
In the text field that appears in the next screen, type "Golden Gate Park". Click the first option "Golden Gate Pkwy, Naples, FL, USA" that appears.
Verify that the 2 markers are on the map and camera moved to show both on the screen.
Added Finish step
Verify that the distance was drawn as expected.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Web.-.Screen.Recording.2023-08-26.at.09.52.07.mov

Mobile Web - Chrome

Web.Mobile.Chrome.-.iPhone.14.Pro.MP4

Mobile Web - Safari

Web.Mobile.Safari.-.Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-08-26.at.09.39.49.mp4

Desktop

Screen.Recording.2023-08-26.at.10.28.32.mov

iOS

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-08-26.at.00.58.04.mp4

Android

Screen.Recording.2023-08-26.at.16.34.28.mov

* Fix Map Panning behavior * Add screen focus state props to MapView Added new props to avoid introducing unnecessary dependencies ('@react-navigation/native') to the 'react-native-x-maps' library. * feat: Move code from react-native-x-maps to the App * fix: rename mapbox consts * fix: Fix app crashing on waypoint delete * Remove unnecessary re exports * Fix react duplicate keys Expensify#35 * Fix Not Found Page appearing issue and add comment * Fix panning issue * fix: add PropTypes import which is mised during conflict resolution

melvin-bot · 2023-09-01T17:10:28Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-09-01T17:12:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-01.at.2.30.23.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-09-01.at.2.48.03.AM.mov

Mobile Web - Safari

Screen.Recording.2023-09-01.at.2.37.04.AM.mov

Desktop

Screen.Recording.2023-09-01.at.3.07.59.AM.mov

iOS

Screen.Recording.2023-09-01.at.2.33.23.AM.mov

Android

Screen.Recording.2023-09-01.at.3.03.36.AM.mov

allroundexperts

Coming from #25977, this PR was already approved.

melvin-bot · 2023-09-01T17:13:20Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25732 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

allroundexperts · 2023-09-01T17:13:40Z

@hayata-suenaga Your review needed here!

neil-marcellini · 2023-09-01T17:22:16Z

@gegham-khachatryan lint is failing

luacmartins

LGMT minus the lint errors

gegham-khachatryan · 2023-09-01T17:25:22Z

Fixing lint errors

gegham-khachatryan · 2023-09-01T17:30:25Z

Inside ConfirmedRoute.js page used MapView from react-native-x-maps

gegham-khachatryan · 2023-09-01T17:41:30Z

@neil-marcellini Lint errors fixed

@allroundexperts Also updated ConfirmedRoute.js component.

gegham-khachatryan · 2023-09-01T17:56:32Z

@hayata-suenaga #26500
New PR opened. Lint errors fixed

hayata-suenaga · 2023-09-01T18:09:38Z

running CI tests again...

hayata-suenaga · 2023-09-01T18:57:51Z

Testing this now...

hayata-suenaga · 2023-09-01T18:58:26Z

@allroundexperts I know this is the copy of the original PR but can you just go through the basic flow just to make sure it still works?

allroundexperts · 2023-09-01T19:14:51Z

@allroundexperts I know this is the copy of the original PR but can you just go through the basic flow just to make sure it still works?

On it!

allroundexperts · 2023-09-01T19:36:36Z

Working good for me!

OSBotify · 2023-09-01T19:45:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-01T23:37:15Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-04T16:21:56Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.62-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ahmedGaber93 · 2023-09-08T18:21:44Z

src/pages/iou/WaypointEditor.js

@@ -161,7 +163,7 @@ function WaypointEditor({transactionID, route: {params: {iouType = '', waypointI
            onEntryTransitionEnd={() => textInput.current && textInput.current.focus()}
            shouldEnableMaxHeight
        >
-            <FullPageNotFoundView shouldShow={Number.isNaN(parsedWaypointIndex) || parsedWaypointIndex < 0 || parsedWaypointIndex > waypointCount - 1}>


@gegham-khachatryan Can you please help explain why do we need to use && isFocused here? Thanks

@ahmedGaber93 There was an issue where when deleting a waypoint, transactions were updated before the page close animation occurred, and the Not Found screen became visible for a few milliseconds during the animation.

mollfpr · 2023-10-15T17:36:06Z

src/components/MapView/utils.ts

@@ -0,0 +1,13 @@
+function getBounds(waypoints: Array<[number, number]>): {southWest: [number, number]; northEast: [number, number]} {
+    const lngs = waypoints.map((waypoint) => waypoint[0]);
+    const lats = waypoints.map((waypoint) => waypoint[1]);


Hi ✋ Coming from #27175

To enhance the bounds, we also should be considering the direction coordinates so it can be zoomed out from the furthest distance.

gegham-khachatryan added 2 commits September 1, 2023 21:07

Merge branch 'Expensify:main' into main

c2e3291

gegham-khachatryan requested a review from a team as a code owner September 1, 2023 17:10

melvin-bot bot requested review from allroundexperts and removed request for a team September 1, 2023 17:10

allroundexperts approved these changes Sep 1, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins September 1, 2023 17:13

neil-marcellini previously approved these changes Sep 1, 2023

View reviewed changes

luacmartins previously approved these changes Sep 1, 2023

View reviewed changes

Fix lint errors, replace MapView import

299d030

gegham-khachatryan dismissed stale reviews from luacmartins and neil-marcellini via 299d030 September 1, 2023 17:39

gegham-khachatryan mentioned this pull request Sep 1, 2023

Map panning fix #25977

Closed

59 tasks

hayata-suenaga self-requested a review September 1, 2023 18:57

neil-marcellini approved these changes Sep 1, 2023

View reviewed changes

hayata-suenaga approved these changes Sep 1, 2023

View reviewed changes

neil-marcellini merged commit a6a0572 into Expensify:main Sep 1, 2023
15 checks passed

hayata-suenaga mentioned this pull request Sep 1, 2023

[Distance] Request money - Map box not zooming to current location #26485

Closed

6 tasks

OSBotify mentioned this pull request Sep 1, 2023

Deploy Checklist: New Expensify 2023-09-01 #26539

Closed

40 tasks

huzaifa-99 mentioned this pull request Sep 2, 2023

Added option to get user's current location #26546

Merged

59 tasks

melvin-bot bot mentioned this pull request Sep 4, 2023

[HOLD for payment 2023-09-11] [$2000] Fix issue with Map panning behavior #25732

Closed

6 tasks

ahmedGaber93 reviewed Sep 8, 2023

View reviewed changes

thesahindia mentioned this pull request Oct 10, 2023

[HOLD for payment 2023-10-09] [$500] Web - App displays waypoint address page briefly on click on 'Go back to Home page' #27106

Closed

6 tasks

mollfpr reviewed Oct 15, 2023

View reviewed changes

mollfpr mentioned this pull request Oct 15, 2023

[HOLD for payment 2023-10-12] [$500] [Distance] Web - Map and map image doesn't zoom out and display long unconventional routes #27175

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Map panning fix (2) #26500

Map panning fix (2) #26500

gegham-khachatryan commented Sep 1, 2023

melvin-bot bot commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

allroundexperts left a comment

melvin-bot bot commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

neil-marcellini commented Sep 1, 2023

luacmartins left a comment

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023 •

edited

Loading

hayata-suenaga commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 4, 2023

ahmedGaber93 Sep 8, 2023

gegham-khachatryan Sep 8, 2023

mollfpr Oct 15, 2023

Map panning fix (2) #26500

Map panning fix (2) #26500

Conversation

gegham-khachatryan commented Sep 1, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

neil-marcellini commented Sep 1, 2023

luacmartins left a comment

Choose a reason for hiding this comment

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

gegham-khachatryan commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023 • edited Loading

hayata-suenaga commented Sep 1, 2023

hayata-suenaga commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

allroundexperts commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 1, 2023

OSBotify commented Sep 4, 2023

ahmedGaber93 Sep 8, 2023

Choose a reason for hiding this comment

gegham-khachatryan Sep 8, 2023

Choose a reason for hiding this comment

mollfpr Oct 15, 2023

Choose a reason for hiding this comment

hayata-suenaga commented Sep 1, 2023 •

edited

Loading