Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316

Merged
merged 17 commits into from
Oct 16, 2023
Merged

[TS migration] Migrate 'BankAccounts.js' lib to TypeScript #28316

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d0460ae
[TS migration] Migrate 'BankAccounts.js' lib
VickyStash Sep 27, 2023
f54ac08
Add OnyxData type
VickyStash Sep 27, 2023
604fa02
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Sep 28, 2023
92c370d
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Sep 29, 2023
0a325e1
Add types for API calls params
VickyStash Sep 29, 2023
831f486
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Sep 29, 2023
da5c57e
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Oct 3, 2023
1e644a8
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Oct 3, 2023
2f8d51f
Types updates
VickyStash Oct 3, 2023
3738181
Remove extra type
VickyStash Oct 3, 2023
8013c20
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Oct 10, 2023
1b1c044
Rename error_description to errorDescription
VickyStash Oct 10, 2023
cbe27b1
Type api requests onyxData as OnyxData
VickyStash Oct 11, 2023
aa0a6ce
Add bank account step type
VickyStash Oct 12, 2023
0aa6dfb
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Oct 13, 2023
3c0246c
Fix ts errors after merging main
VickyStash Oct 16, 2023
9d99ed0
Merge branch 'main' into ts-migration/bank-accounts-lib
VickyStash Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/Navigation/Navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ const getActiveRouteIndex = function (route, index) {
/**
* Main navigation method for redirecting to a route.
* @param {String} route
* @param {String} type - Type of action to perform. Currently UP is supported.
* @param {String} [type] - Type of action to perform. Currently UP is supported.
*/
function navigate(route = ROUTES.HOME, type) {
if (!canNavigate('navigate', {route})) {
Expand Down
Loading
Loading