Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "fix: use the same sort order for header display names and avatars in a group chat view" #28929

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[CP Staging] Revert "fix: use the same sort order for header display names and avatars in a group chat view" #28929

merged 1 commit into from
Oct 5, 2023

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Oct 5, 2023 •
edited
Loading

Staright Revert #28218

Fixes a deploy blocker where room name is changed to participant names list https://expensify.slack.com/archives/C01GTK53T8Q/p1696510155669379

#28930

@mountiny mountiny self-assigned this Oct 5, 2023
@mountiny mountiny requested a review from a team as a code owner October 5, 2023 16:02
@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team October 5, 2023 16:03
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f493422
Status: ✅  Deploy successful!
Preview URL: https://ffb94821.helpdot.pages.dev
Branch Preview URL: https://revert-28218-task-28048.helpdot.pages.dev

View logs

@mountiny
Copy link
Contributor Author

mountiny commented Oct 5, 2023

main, staging:
image

After revert
image

@srikarparsi srikarparsi merged commit 9d4e3bd into main Oct 5, 2023
11 of 15 checks passed
@srikarparsi srikarparsi deleted the revert-28218-task-28048 branch October 5, 2023 16:41
@melvin-bot melvin-bot bot added the Emergency label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@srikarparsi
Copy link
Contributor

straight revert, removing emergency

@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 5, 2023
@srikarparsi @OSBotify
Merge pull request #28929 from Expensify/revert-28218-task-28048
0432c28 
[CP Staging] Revert "fix: use the same sort order for header display names and avatars in a group chat view"

(cherry picked from commit 9d4e3bd)
@OSBotify OSBotify mentioned this pull request Oct 5, 2023
Closed
57 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2023

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.78-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2023

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikarparsi srikarparsi srikarparsi approved these changes

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mountiny @srikarparsi @OSBotify