[CP Staging] Fix disabled chevron of "MenuItem" #28931

rezkiy37 · 2023-10-05T16:19:22Z

Details

This is a hight priority fix, because an attached issue is a deploy blocker, is regression from - #28919.
There was replaced a wrapper of a right icon of MenuItem. The icon is a pressable component now, but it is not required. Moreover, some new props are never been used.

Fixed Issues

$ #28919
PROPOSAL: N/A

Tests

Hovering menu items

Click on the "FAB" button.
Click on "Assign task".
Enter any value to "Title".
Click on "Next".
Hover over the chevron icon of "Title", "Assignee", "Description", and "Share somewhere" fields.
Verify that there is not "no-entry mouse sign".
Click on the chevron icon of a field.
Verify that the icon is clickable and it works the same as you click in a different part of the field.

Markup of "Reveal details" for the digital card

Please do test from here - Add “Reveal details” for the digital card #26778 (comment).
Please compare UI/UX with videos there.
Verify that no changes on the flow.

Verify that no errors appear in the JS console

Offline tests

Same as "Tests".

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Chrome.Assign.Task.mp4

Chrome.Card.mp4

Mobile Web - Chrome

Android.Chrome.Assign.Task.mov

Android.Chrome.Card.mov

Mobile Web - Safari

IOS.Safari.Assign.Task.mov

IOS.Safari.Task.mov

Desktop

Desktop.Assign.Task.mp4

Desktop.Card.mp4

iOS

IOS.Assign.Task.mov

IOS.Card.mov

Android

Android.Assign.Task.mov

Android.Card.mov

rezkiy37 · 2023-10-05T18:18:54Z

Having troubles with launching the app on native Android. However, it is not a critical to block a PR. Opening for review.

cc @mountiny

melvin-bot · 2023-10-05T18:19:02Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

This is basically partial revert of https://github.com/Expensify/App/pull/26778/files

mountiny · 2023-10-05T18:35:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-05.at.19.36.06.mp4

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-10-05.at.19.41.22.mov

Desktop

iOS

Android

rezkiy37 · 2023-10-05T18:37:01Z

Just solved problems with Android. Added videos.

OSBotify · 2023-10-05T18:51:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…confirm-task [CP Staging] Fix disabled chevron of "MenuItem" (cherry picked from commit 74ce732)

OSBotify · 2023-10-05T20:44:18Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.78-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-06T07:52:45Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.78-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

remove extra props

9987574

rezkiy37 marked this pull request as ready for review October 5, 2023 18:18

rezkiy37 requested a review from a team as a code owner October 5, 2023 18:18

melvin-bot bot requested review from parasharrajat and removed request for a team October 5, 2023 18:19

mountiny changed the title ~~Fix disabled chevron of "MenuItem"~~ [CP Staging] Fix disabled chevron of "MenuItem" Oct 5, 2023

mountiny assigned rezkiy37 Oct 5, 2023

mountiny approved these changes Oct 5, 2023

View reviewed changes

mountiny merged commit 74ce732 into Expensify:main Oct 5, 2023
14 of 20 checks passed

OSBotify pushed a commit that referenced this pull request Oct 5, 2023

Merge pull request #28931 from rezkiy37/fix/28919-disabled-fields-on-…

e57db58

…confirm-task [CP Staging] Fix disabled chevron of "MenuItem" (cherry picked from commit 74ce732)

OSBotify mentioned this pull request Oct 5, 2023

Deploy Checklist: New Expensify 2023-10-05 #28883

Closed

57 tasks

melvin-bot bot mentioned this pull request Oct 6, 2023

[HOLD for payment 2023-10-16] [HOLD for payment 2023-10-13] Task - No-entry mouse sign is displayed when hovering over 'Chevron' icon options displayed on 'Confirm task' page #28919

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix disabled chevron of "MenuItem" #28931

[CP Staging] Fix disabled chevron of "MenuItem" #28931

rezkiy37 commented Oct 5, 2023 •

edited

Loading

rezkiy37 commented Oct 5, 2023 •

edited

Loading

melvin-bot bot commented Oct 5, 2023

mountiny left a comment

mountiny commented Oct 5, 2023 •

edited

Loading

rezkiy37 commented Oct 5, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

[CP Staging] Fix disabled chevron of "MenuItem" #28931

[CP Staging] Fix disabled chevron of "MenuItem" #28931

Conversation

rezkiy37 commented Oct 5, 2023 • edited Loading

Details

Fixed Issues

Tests

Hovering menu items

Markup of "Reveal details" for the digital card

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rezkiy37 commented Oct 5, 2023 • edited Loading

melvin-bot bot commented Oct 5, 2023

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Oct 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rezkiy37 commented Oct 5, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

rezkiy37 commented Oct 5, 2023 •

edited

Loading

rezkiy37 commented Oct 5, 2023 •

edited

Loading

mountiny commented Oct 5, 2023 •

edited

Loading