From f0b5986126073f4d8dab221dede715071774061a Mon Sep 17 00:00:00 2001 From: Luthfi Date: Wed, 1 Nov 2023 20:20:15 +0700 Subject: [PATCH 1/4] add form input styles checklist --- contributingGuides/REVIEWER_CHECKLIST.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contributingGuides/REVIEWER_CHECKLIST.md b/contributingGuides/REVIEWER_CHECKLIST.md index 16c8f88927b1..51908d696c1d 100644 --- a/contributingGuides/REVIEWER_CHECKLIST.md +++ b/contributingGuides/REVIEWER_CHECKLIST.md @@ -51,6 +51,9 @@ - [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases) - [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. - [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. +- [ ] If the PR modifies the form input styles: + - [ ] All the inputs inside a form should be aligned with each other + - [ ] Add the Design label so the Design team can review your changes - [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page. - [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps. - [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR. From 61da6b547ba5abe206d813b7631d593e397a4de8 Mon Sep 17 00:00:00 2001 From: Luthfi Date: Wed, 1 Nov 2023 20:27:59 +0700 Subject: [PATCH 2/4] Add the checklist to the PR template --- .github/PULL_REQUEST_TEMPLATE.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0396a7543b50..e516b8b3e0e1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -114,6 +114,9 @@ This is a checklist for PR authors. Please make sure to complete all tasks and c - [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases) - [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. - [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. +- [ ] If the PR modifies the form input styles: + - [ ] All the inputs inside a form should be aligned with each other + - [ ] Add the Design label so the Design team can review your changes - [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page. - [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps. - [ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR. From 7130c0addcd184831f6274ee3806d09766698609 Mon Sep 17 00:00:00 2001 From: Luthfi Date: Wed, 20 Dec 2023 18:30:21 +0700 Subject: [PATCH 3/4] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: 0xmiroslav <97473779+0xmiroslav@users.noreply.github.com> --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e516b8b3e0e1..19b62f0f93d8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -115,8 +115,8 @@ This is a checklist for PR authors. Please make sure to complete all tasks and c - [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. - [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. - [ ] If the PR modifies the form input styles: - - [ ] All the inputs inside a form should be aligned with each other - - [ ] Add the Design label so the Design team can review your changes + - [ ] I verified that all the inputs inside a form are aligned with each other. + - [ ] I added `Design` label so the design team can review the changes. - [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page. - [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps. - [ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR. From 5376ab570b40b4d27b53075ebb1626e88aaa5b76 Mon Sep 17 00:00:00 2001 From: Luthfi Date: Wed, 20 Dec 2023 18:32:28 +0700 Subject: [PATCH 4/4] update the reviewer checklist --- contributingGuides/REVIEWER_CHECKLIST.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contributingGuides/REVIEWER_CHECKLIST.md b/contributingGuides/REVIEWER_CHECKLIST.md index 51908d696c1d..146c170a15cf 100644 --- a/contributingGuides/REVIEWER_CHECKLIST.md +++ b/contributingGuides/REVIEWER_CHECKLIST.md @@ -52,8 +52,8 @@ - [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. - [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. - [ ] If the PR modifies the form input styles: - - [ ] All the inputs inside a form should be aligned with each other - - [ ] Add the Design label so the Design team can review your changes + - [ ] I verified that all the inputs inside a form are aligned with each other. + - [ ] I added `Design` label so the design team can review the changes. - [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page. - [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps. - [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.