-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ws options available from all devices for same user #42008
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
adf4099
Fix: ws options available from all devices for same user
dragnoir b5d94a9
Merge branch 'Expensify:main' into 40686-fix
dragnoir 16145e9
revert isPolicyAdmin
dragnoir 67e0f08
fix policyUtility
dragnoir 7eaeda0
fix role not available
dragnoir 9ec30ac
fix admin when not on policy
dragnoir 349b220
move employe check into isPolicyAdmin
dragnoir 64a9e26
better approach
dragnoir 1aeaaee
fix lint
dragnoir 799d626
Merge branch 'Expensify:main' into 40686-fix
dragnoir f0b1770
Merge branch 'Expensify:main' into 40686-fix
dragnoir 2f349db
same logic for AccessOrNotFoundWrapper
dragnoir f9e0e16
Merge remote-tracking branch 'upstream/main' into 40686-fix
dragnoir ca4d45f
fix ts
dragnoir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the
= ''
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS error, login can be undefined, and one of the solutions is to set a default value.