From 99efaceca6cff5ea7abe559bcc1e06004be4fc92 Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Fri, 24 May 2024 10:24:50 +0700 Subject: [PATCH 1/2] fix: User is already a member of the Workspace message is missing --- src/components/SelectionList/BaseSelectionList.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/SelectionList/BaseSelectionList.tsx b/src/components/SelectionList/BaseSelectionList.tsx index 77b296740f2c..8f18984080ce 100644 --- a/src/components/SelectionList/BaseSelectionList.tsx +++ b/src/components/SelectionList/BaseSelectionList.tsx @@ -559,7 +559,7 @@ function BaseSelectionList( )} {/* If we are loading new options we will avoid showing any header message. This is mostly because one of the header messages says there are no options. */} {/* This is misleading because we might be in the process of loading fresh options from the server. */} - {!isLoadingNewOptions && !!headerMessage && ( + {(!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) && ( {headerMessage} From 5540a63b169cad64988617229da8979e6bca2b82 Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Mon, 27 May 2024 19:33:47 +0700 Subject: [PATCH 2/2] update condition --- src/components/SelectionList/BaseSelectionList.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/SelectionList/BaseSelectionList.tsx b/src/components/SelectionList/BaseSelectionList.tsx index 4f09e980e0a5..24541fe40c3a 100644 --- a/src/components/SelectionList/BaseSelectionList.tsx +++ b/src/components/SelectionList/BaseSelectionList.tsx @@ -609,7 +609,7 @@ function BaseSelectionList( )} {/* If we are loading new options we will avoid showing any header message. This is mostly because one of the header messages says there are no options. */} {/* This is misleading because we might be in the process of loading fresh options from the server. */} - {(!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) && ( + {(!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) && !!headerMessage && ( {headerMessage}