Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error above Submit button is delayed by a moment when sending invoice without merchant #43455

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Fix error above Submit button is delayed by a moment when sending invoice without merchant #43455

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
814532e
use debounced form error for split request only
bernhardoj Jun 11, 2024
d986e5e
add missing deps
bernhardoj Jun 11, 2024
f1a778a
Merge branch 'main' into fix/43184-error-shown-with-delay
bernhardoj Jun 13, 2024
ca753e7
prettier
bernhardoj Jun 13, 2024
7f6b422
Merge branch 'main' into fix/43184-error-shown-with-delay
bernhardoj Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/MoneyRequestConfirmationList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ function MoneyRequestConfirmationList({
<FormHelpMessage
style={[styles.ph1, styles.mb2]}
isError
message={!shouldShowReadOnlySplits ? debouncedFormError : formError}
message={(isTypeSplit && !shouldShowReadOnlySplits) ? debouncedFormError : formError}
/>
)}

Expand All @@ -826,6 +826,7 @@ function MoneyRequestConfirmationList({
);
}, [
isReadOnly,
isTypeSplit,
iouType,
selectedParticipants.length,
confirm,
Expand Down
Loading