Add basic version of AdvancedFilters Page #45407

Kicu · 2024-07-15T15:20:16Z

Details

adds very basic version of advanced filters page, to allow for further development of specific filter pages
only basic routing works, no data or saving form values works yet - these will be added in separate PRs, a few each. We believe that we will be able to use FormProvider to implement each of the sub-pages
right now if you go to /search/filters the RHP will look correctly however the page underneath RHP - Search - will look broken. That is to be expected, and it will be fixed in [HOLD for payment 2024-08-05] [Search v2.1] [App] Use new query syntax #45027 - once we have new query functionality, it will be handled by defaults from parser

Fixed Issues

$ #45026
PROPOSAL:

Tests

navigate to /search/filters
test that it renders correctly with some static temporary data
test that navigation within the advanced filters view works
on large screen the screen below should be broken, that is expected temporarily

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

rec-andr-filters.mov

Android: mWeb Chrome

iOS: Native

rec-ios-filters.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

rec-web-filters.mp4

MacOS: Desktop

…are-mansion-labs/expensify-app-fork into Guccio163/45026-search-advanced-filters

…rch-advanced-filters Date advanced filter rhp, empty

github-actions · 2024-07-17T14:17:07Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2024-07-17T15:07:17Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Kicu · 2024-07-17T15:07:48Z

@luacmartins ready for review, will verify that android builds correctly and update the description later. Android builds always take ages to complete.

// update
android works as well

Kicu · 2024-07-17T15:08:47Z

src/languages/es.ts

+        filters: {
+            date: {
+                before: 'Antes',
+                after: 'Después',


can you verify these translations @luacmartins

src/pages/Search/AdvancedSearchFilters.tsx

src/libs/Navigation/types.ts

src/pages/Search/AdvancedSearchFilters.tsx

rayane-djouah · 2024-07-17T17:25:07Z

src/pages/Search/SearchFilters.tsx

@@ -25,6 +25,7 @@ type SearchMenuFilterItem = {
    route: Route;
 };

+// Because we will add have AdvancedFilters, in future rename this component to `SearchTypeMenu|Tabs|Filters` to avoid confusion


Suggested change

// Because we will add have AdvancedFilters, in future rename this component to `SearchTypeMenu|Tabs|Filters` to avoid confusion

// TODO: Because we will add AdvancedFilters component, in future rename this component to `SearchTypeMenu|Tabs|Filters` to avoid confusion

We can already rename this to SearchStatusBar

Sorry but this can't be SearchStatusBar because this is the component that is currently (and for now still will be) displayed in LHN. So this is not the moment to rename it or it will confuse developers.

We should rename it I think when we are actually removing it from LHN - which this PR is not doing.
CC @adamgrzybowski @WojtekBoman

src/pages/Search/AdvancedSearchFilters.tsx

rayane-djouah · 2024-07-17T18:05:40Z

BUG 1: Url in browser does not change from /search/filters to /search/filters/type (for example) when opening the filter page

Screen.Recording.2024-07-17.at.6.48.48.PM.mov

rayane-djouah · 2024-07-17T18:05:44Z

BUG 2: No animation when closing the type/date filter page on mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-17.at.18.55.39.mp4

rayane-djouah · 2024-07-17T18:08:26Z

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-17.at.7.04.43.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-17.at.7.03.42.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-17.at.19.02.55.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-17.at.18.55.39.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-07-17.at.6.48.48.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-17.at.6.54.41.PM.mov

luacmartins · 2024-07-17T19:11:58Z

@Guccio163 since you committed to this PR, can you please sign the CLA? #45407 (comment)

src/languages/es.ts

src/ROUTES.ts

src/pages/Search/AdvancedSearchFilters.tsx

src/pages/Search/SearchAdvancedFiltersPage.tsx

luacmartins · 2024-07-17T19:40:12Z

src/pages/Search/SearchFilters.tsx

@@ -25,6 +25,7 @@ type SearchMenuFilterItem = {
    route: Route;
 };

+// Because we will add have AdvancedFilters, in future rename this component to `SearchTypeMenu|Tabs|Filters` to avoid confusion


We can already rename this to SearchStatusBar

src/pages/Search/SearchFiltersDatePage.tsx

src/pages/Search/SearchFiltersTypePage.tsx

Guccio163 · 2024-07-18T06:42:08Z

I have read the CLA Document and I hereby sign the CLA

Kicu · 2024-07-18T13:26:19Z

@luacmartins I addressed most of your comments but responded in 2 cases why I prefer the current version
@rayane-djouah I addressed all your comments (I hope 😄)

BUG1 - solved, I've made a mistake when defining ROUTES
BUG2 - this is known and appears on main. This specific animation is disabled for Safari temporarily until we find a better solution. [CHECKLIST - ISHPAUL] [$250] Mac Safari - Tasks/Chat - Second right hand menu pane RHP shown severely cut compared to prod #44765

luacmartins

LGTM! Nice work!

luacmartins · 2024-07-18T15:37:19Z

@rayane-djouah all yours!

rayane-djouah · 2024-07-18T16:10:27Z

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-18.at.5.09.36.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-18.at.5.06.31.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-18.at.17.06.21.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-18.at.17.03.58.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-07-18.at.5.02.29.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-18.at.5.02.58.PM.mov

rayane-djouah

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

luacmartins · 2024-07-18T16:18:58Z

Thanks for working on this @Kicu and for the review @rayane-djouah! Let's get the other filter pages moving!

OSBotify · 2024-07-18T16:23:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-19T20:13:48Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-22T13:36:04Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-23T08:03:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-25T03:15:00Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Kicu added 4 commits July 15, 2024 17:18

Add basic skeleton for AdvancedFilters view

f947595

Add AdvancedSearchFilters component with sample static filters

44dccfc

Fix lint for AdvancedFilters

e402736

Update route for SearchAdvancedFiltersPage

7646837

luacmartins self-requested a review July 16, 2024 17:07

Guccio163 and others added 5 commits July 17, 2024 14:27

date advanced filter rhp, empty

8fd23a6

Merge branch 'kicu/45026-search-advanced-filters' of github.com:softw…

7bcb22a

…are-mansion-labs/expensify-app-fork into Guccio163/45026-search-advanced-filters

updating pr with resolving comments

a141d0e

undo the tsconfig.json change

27b4769

Merge pull request #94 from software-mansion-labs/Guccio163/45026-sea…

1352afb

…rch-advanced-filters Date advanced filter rhp, empty

Kicu added 3 commits July 17, 2024 16:20

fix prettier on linkingConfig

1e617f6

cleanup basic skeleton for advanced filters

91df1af

Merge branch 'main' into kicu/45026-search-advanced-filters

f34caca

Kicu changed the title ~~Add AdvancedFilters Page~~ Add basic version of AdvancedFilters Page Jul 17, 2024

Remove consolelog

4d061b0

Kicu marked this pull request as ready for review July 17, 2024 15:07

Kicu requested a review from a team as a code owner July 17, 2024 15:07

melvin-bot bot requested review from rayane-djouah and removed request for a team July 17, 2024 15:07

Kicu commented Jul 17, 2024

View reviewed changes

add small naming fixes

1576b7f

rayane-djouah suggested changes Jul 17, 2024

View reviewed changes

luacmartins requested changes Jul 17, 2024

View reviewed changes

Kicu added 3 commits July 18, 2024 13:56

Add fixes after review to new search filters

d5d84d0

Merge branch 'main' into kicu/45026-search-advanced-filters

64428d9

Refactor advanced filters definition

45e3484

luacmartins approved these changes Jul 18, 2024

View reviewed changes

rayane-djouah approved these changes Jul 18, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins July 18, 2024 16:11

luacmartins approved these changes Jul 18, 2024

View reviewed changes

luacmartins merged commit 58fc7e4 into Expensify:main Jul 18, 2024
15 of 18 checks passed

rayane-djouah mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-08-07] [Search v2.1] [App] Create advanced filters #45026

Closed

1 task

github-actions bot mentioned this pull request Jul 19, 2024

Deploy Checklist: New Expensify 2024-07-19 #45794

Closed

rayane-djouah mentioned this pull request Aug 1, 2024

Use new Search query syntax when calling api #46481

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic version of AdvancedFilters Page #45407

Add basic version of AdvancedFilters Page #45407

Kicu commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

melvin-bot bot commented Jul 17, 2024

Kicu commented Jul 17, 2024 •

edited

Loading

Kicu Jul 17, 2024

rayane-djouah Jul 17, 2024

luacmartins Jul 17, 2024

Kicu Jul 18, 2024

rayane-djouah commented Jul 17, 2024 •

edited

Loading

rayane-djouah commented Jul 17, 2024 •

edited

Loading

rayane-djouah commented Jul 17, 2024

luacmartins commented Jul 17, 2024

luacmartins Jul 17, 2024

Guccio163 commented Jul 18, 2024

Kicu commented Jul 18, 2024 •

edited

Loading

luacmartins left a comment

luacmartins commented Jul 18, 2024

rayane-djouah commented Jul 18, 2024 •

edited

Loading

rayane-djouah left a comment

luacmartins commented Jul 18, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 25, 2024

	// Because we will add have AdvancedFilters, in future rename this component to `SearchTypeMenu\|Tabs\|Filters` to avoid confusion
	// TODO: Because we will add AdvancedFilters component, in future rename this component to `SearchTypeMenu\|Tabs\|Filters` to avoid confusion

Add basic version of AdvancedFilters Page #45407

Add basic version of AdvancedFilters Page #45407

Conversation

Kicu commented Jul 15, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Jul 17, 2024 • edited Loading

melvin-bot bot commented Jul 17, 2024

Kicu commented Jul 17, 2024 • edited Loading

Kicu Jul 17, 2024

Choose a reason for hiding this comment

rayane-djouah Jul 17, 2024

Choose a reason for hiding this comment

luacmartins Jul 17, 2024

Choose a reason for hiding this comment

Kicu Jul 18, 2024

Choose a reason for hiding this comment

rayane-djouah commented Jul 17, 2024 • edited Loading

rayane-djouah commented Jul 17, 2024 • edited Loading

rayane-djouah commented Jul 17, 2024

Screenshots/Videos

luacmartins commented Jul 17, 2024

luacmartins Jul 17, 2024

Choose a reason for hiding this comment

Guccio163 commented Jul 18, 2024

Kicu commented Jul 18, 2024 • edited Loading

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Jul 18, 2024

rayane-djouah commented Jul 18, 2024 • edited Loading

Screenshots/Videos

rayane-djouah left a comment

Choose a reason for hiding this comment

Reviewer Checklist

luacmartins commented Jul 18, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 25, 2024

Kicu commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

Kicu commented Jul 17, 2024 •

edited

Loading

rayane-djouah commented Jul 17, 2024 •

edited

Loading

rayane-djouah commented Jul 17, 2024 •

edited

Loading

Kicu commented Jul 18, 2024 •

edited

Loading

rayane-djouah commented Jul 18, 2024 •

edited

Loading