-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "Add support for viewing full screen Group Chat custom avatars" #45863
Conversation
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Straight revert |
[CP Staging] Revert "Add support for viewing full screen Group Chat custom avatars" (cherry picked from commit a9a45ac)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀
|
Staright revert #41586
Details
This revert fixes showing avatars in the full screen mode
Fixed Issues
$ #45842
$ #45824
Tests
QA confirmed this was fixed https://expensify.slack.com/archives/C9YU7BX5M/p1721651193695839?thread_ts=1721649904.456749&cid=C9YU7BX5M
Offline tests
N/A
QA Steps
Same as tests