-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OldDot Rules Migration] Add "Rules" Row/toggle to "More Features" page #47083
Changes from 15 commits
4394c62
8dcdd0c
d106bdb
f739ff4
5473fc3
74269b2
74fe492
00b4cfa
954cf58
af6227a
02ae07b
9f237c2
068f9a6
b70d783
d886ef5
3d9e73a
f46888e
c525d10
3f574fb
4b24592
79f5b7c
2bdd769
1fd206a
8970dd4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2100,6 +2100,7 @@ export default { | |
travel: 'Travel', | ||
members: 'Members', | ||
accounting: 'Accounting', | ||
rules: 'Rules', | ||
displayedAs: 'Displayed as', | ||
plan: 'Plan', | ||
profile: 'Profile', | ||
|
@@ -2809,6 +2810,10 @@ export default { | |
title: 'Spend', | ||
subtitle: 'Enable optional functionality that helps you scale your team.', | ||
}, | ||
manageSection: { | ||
title: 'Manage', | ||
subtitle: 'Add controls that help keep spend within budget.', | ||
}, | ||
earnSection: { | ||
title: 'Earn', | ||
subtitle: 'Enable optional functionality to streamline your revenue and get paid faster.', | ||
|
@@ -2876,6 +2881,10 @@ export default { | |
disconnectText: "To disable accounting, you'll need to disconnect your accounting connection from your workspace.", | ||
manageSettings: 'Manage settings', | ||
}, | ||
rules: { | ||
title: 'Rules', | ||
subtitle: 'Configure when receipts are required, flag high spend, and more.', | ||
}, | ||
}, | ||
reportFields: { | ||
addField: 'Add field', | ||
|
@@ -3515,6 +3524,11 @@ export default { | |
description: `Add tax codes to your taxes for easy export of expenses to your accounting and payroll systems.`, | ||
onlyAvailableOnPlan: 'Tax codes are only available on the Control plan, starting at ', | ||
}, | ||
rules: { | ||
title: 'Rules', | ||
description: `Rules run in the background and keep your spend under control so you don't have to sweat the small stuff.\n\nRequire expense details like receipts and descriptions, set limits and defaults, and automate approvals and payments – all in one place.`, | ||
onlyAvailableOnPlan: 'Rules are only available on the Control plan, starting at ', | ||
}, | ||
pricing: { | ||
amount: '$9 ', | ||
perActiveMember: 'per active member per month.', | ||
|
@@ -3546,6 +3560,16 @@ export default { | |
chatInAdmins: 'Chat in #admins', | ||
addPaymentCard: 'Add payment card', | ||
}, | ||
rules: { | ||
individualExpenseRules: { | ||
title: 'Expenses', | ||
subtitle: 'Set spend controls and defaults for individual expenses. You can also create rules for categories and tags.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did we want "categories" and "tags" to be links? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, these should be links :) I've already fixed that Screen.Recording.2024-08-19.at.15.59.16.movScreen.Recording.2024-08-19.at.15.58.44.mov |
||
}, | ||
expenseReportRules: { | ||
title: 'Expense reports', | ||
subtitle: 'Automate expense report compliance, approvals, and payment.', | ||
}, | ||
}, | ||
}, | ||
getAssistancePage: { | ||
title: 'Get assistance', | ||
|
marcaaron marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
type SetPolicyRulesEnabledParams = { | ||
policyID: string; | ||
enabled: boolean; | ||
}; | ||
|
||
export default SetPolicyRulesEnabledParams; |
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -198,6 +198,7 @@ const WRITE_COMMANDS = { | |||
ENABLE_POLICY_REPORT_FIELDS: 'EnablePolicyReportFields', | ||||
ENABLE_POLICY_EXPENSIFY_CARDS: 'EnablePolicyExpensifyCards', | ||||
ENABLE_POLICY_INVOICING: 'EnablePolicyInvoicing', | ||||
SET_POLICY_RULES_ENABLED: 'SetPolicyRulesEnabled', | ||||
SET_POLICY_TAXES_CURRENCY_DEFAULT: 'SetPolicyCurrencyDefaultTax', | ||||
SET_POLICY_TAXES_FOREIGN_CURRENCY_DEFAULT: 'SetPolicyForeignCurrencyDefaultTax', | ||||
SET_POLICY_CUSTOM_TAX_NAME: 'SetPolicyCustomTaxName', | ||||
|
@@ -525,6 +526,7 @@ type WriteCommandParameters = { | |||
[WRITE_COMMANDS.ENABLE_POLICY_REPORT_FIELDS]: Parameters.EnablePolicyReportFieldsParams; | ||||
[WRITE_COMMANDS.ENABLE_POLICY_EXPENSIFY_CARDS]: Parameters.EnablePolicyExpensifyCardsParams; | ||||
[WRITE_COMMANDS.ENABLE_POLICY_INVOICING]: Parameters.EnablePolicyInvoicingParams; | ||||
[WRITE_COMMANDS.SET_POLICY_RULES_ENABLED]: Parameters.SetPolicyRulesEnabledParams; | ||||
[WRITE_COMMANDS.JOIN_POLICY_VIA_INVITE_LINK]: Parameters.JoinPolicyInviteLinkParams; | ||||
[WRITE_COMMANDS.ACCEPT_JOIN_REQUEST]: Parameters.AcceptJoinRequestParams; | ||||
[WRITE_COMMANDS.DECLINE_JOIN_REQUEST]: Parameters.DeclineJoinRequestParams; | ||||
|
@@ -548,6 +550,7 @@ type WriteCommandParameters = { | |||
[WRITE_COMMANDS.REQUEST_EXPENSIFY_CARD_LIMIT_INCREASE]: Parameters.RequestExpensifyCardLimitIncreaseParams; | ||||
[WRITE_COMMANDS.CLEAR_OUTSTANDING_BALANCE]: null; | ||||
[WRITE_COMMANDS.CANCEL_BILLING_SUBSCRIPTION]: Parameters.CancelBillingSubscriptionParams; | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_ENABLE_NEW_CATEGORIES]: Parameters.UpdateQuickbooksOnlineGenericTypeParams; | ||||
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_AUTO_CREATE_VENDOR]: Parameters.UpdateQuickbooksOnlineGenericTypeParams; | ||||
[WRITE_COMMANDS.UPDATE_QUICKBOOKS_ONLINE_REIMBURSABLE_EXPENSES_ACCOUNT]: Parameters.UpdateQuickbooksOnlineGenericTypeParams; | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this
DISABLED_MAX_EXPENSE_VALUE
and just use it for all three of these cases?