From 07e6cea43a980fc7876b25d56cbe7ffec42f3638 Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Wed, 18 Aug 2021 10:47:11 +0100 Subject: [PATCH 1/4] Update the PR template to enforce formatting of the linked issues --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 632da16035b1..a005837deb0a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,7 +4,15 @@ ### Fixed Issues - + $ GH_LINK ### Tests From 7846ed3b0bba8d37dd0577aece628904ab6f0e62 Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Wed, 18 Aug 2021 10:47:31 +0100 Subject: [PATCH 2/4] Remove dummy change introduced during testing webhook feature --- test.md | 1 - 1 file changed, 1 deletion(-) delete mode 100644 test.md diff --git a/test.md b/test.md deleted file mode 100644 index db0d8318b8f5..000000000000 --- a/test.md +++ /dev/null @@ -1 +0,0 @@ -This is for testing purposes, I will remove this file in subsequent PR. \ No newline at end of file From df765209dc30e53be8294700261a86753fa584a8 Mon Sep 17 00:00:00 2001 From: Vit Horacek <36083550+mountiny@users.noreply.github.com> Date: Thu, 19 Aug 2021 11:52:27 +0200 Subject: [PATCH 3/4] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Aldo Canepa Garay <87341702+aldo-expensify@users.noreply.github.com> --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a005837deb0a..65aa684b6d51 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ Please replace GH_LINK with the link to the GitHub issue this Pull Request is fi Do NOT add the special GH keywords like `fixed` etc, we have our own process of managing the flow. It MUST be an entire link to the issue, otherwise the linking will not work as expected. -Make sure this section looks similar to this (you can link multiple issues using the same formatting, just add new line): +Make sure this section looks similar to this (you can link multiple issues using the same formatting, just add a new line): $ https://github.com/Expensify/App/issues/4723 ---> From 71fe291df76eaea02e2b9dbe41c8ed5e6cbe30d8 Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Thu, 19 Aug 2021 17:47:00 +0100 Subject: [PATCH 4/4] Update grammar --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 65aa684b6d51..e1bef835fe07 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,7 +7,7 @@