Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "Remove members" and "Make admin" options are present for owner #47257

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Fix: "Remove members" and "Make admin" options are present for owner #47257

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70d8dd1
Add disabled check when triggering modal
neonbhai Aug 12, 2024
38daa23
Merge branch 'Expensify:main' into selection-list-modal-fix
neonbhai Aug 13, 2024
947662b
Merge branch 'Expensify:main' into selection-list-modal-fix
neonbhai Aug 16, 2024
f8eed58
disable eslint warning for prefer-nullish-coalescing
neonbhai Aug 16, 2024
8a4380b
Merge branch 'Expensify:main' into selection-list-modal-fix
neonbhai Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/SelectionListWithModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ function SelectionListWithModal<TItem extends ListItem>(
}, [sections, selectionMode, isSmallScreenWidth]);

const handleLongPressRow = (item: TItem) => {
if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth) {
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
neonbhai marked this conversation as resolved.
Show resolved Hide resolved
if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox) {
return;
}
setLongPressedItem(item);
Expand Down
Loading