[NO QA] Add combinedTrackSubmit beta to permissions #47921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grgia
commented
Aug 23, 2024
src/CONST.ts
Outdated
| @@ -384,6 +384,7 @@ const CONST = { | |||
| WORKSPACE_FEEDS: 'workspaceFeeds', | |||
| NETSUITE_USA_TAX: 'netsuiteUsaTax', | |||
| WORKSPACE_RULES: 'workspaceRules', | |||
| COMBINED_CREATE_EXPENSE: 'combinedCreateExpense', | |||
There was a problem hiding this comment.
Waiting to confirm this name in the web PR
melvin-bot
bot
requested review from
eVoloshchak
and removed request for
a team
|
@eVoloshchak @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
grgia
commented
Aug 23, 2024
src/libs/Permissions.ts
Outdated
| @@ -40,6 +40,11 @@ function canUseWorkspaceRules(betas: OnyxEntry<Beta[]>): boolean { | |||
| return !!betas?.includes(CONST.BETAS.WORKSPACE_RULES) || canUseAllBetas(betas); | |||
| } | |||
|
|
|||
| function canUseCombinedCreateExpense(betas: OnyxEntry<Beta[]>): boolean { | |||
| // We don't need to show this to all betas. | |||
There was a problem hiding this comment.
Context: we mainly need this beta for developing the feature. We will likely develop a new system for handling A/B testing
dangrous
approved these changes
Aug 23, 2024
|
@dangrous could you add the checklist? no QA for this |
grgia
changed the title
grgia
changed the title
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
ah whoops sorry! checklist is checked, this is good to go |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions
bot
added
the
DeployBlockerCash
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.25-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.25-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a TEMPORARY beta for developing this feature while we decide how to show it to users.
Web PR - https://github.com/Expensify/Web-Expensify/pull/43249
Adding this so we can start building #47598
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/422767
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop