From d3da46e12ae048c3d1bcf23c1d5e8b80180aede6 Mon Sep 17 00:00:00 2001 From: Alex Beaman Date: Thu, 5 Sep 2024 11:25:01 -0600 Subject: [PATCH] Show in LHN even if report not in submitted state/status --- src/libs/ReportUtils.ts | 6 +++--- src/libs/SidebarUtils.ts | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index 7b226b2e5c8e..7b42ba3789d9 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -7775,8 +7775,8 @@ function hasMissingInvoiceBankAccount(iouReportID: string): boolean { return invoiceReport?.ownerAccountID === currentUserAccountID && isEmptyObject(getPolicy(invoiceReport?.policyID)?.invoice?.bankAccount ?? {}) && isSettled(iouReportID); } -function isSubmittedExpenseReportManagerWithoutParentAccess(report: OnyxEntry) { - return isExpenseReport(report) && report?.hasParentAccess === false && report?.managerID === currentUserAccountID && isProcessingReport(report); +function isExpenseReportManagerWithoutParentAccess(report: OnyxEntry) { + return isExpenseReport(report) && report?.hasParentAccess === false && report?.managerID === currentUserAccountID; } export { @@ -7975,7 +7975,7 @@ export { isEmptyReport, isRootGroupChat, isExpenseReport, - isSubmittedExpenseReportManagerWithoutParentAccess, + isExpenseReportManagerWithoutParentAccess, isExpenseRequest, isExpensifyOnlyParticipantInReport, isGroupChat, diff --git a/src/libs/SidebarUtils.ts b/src/libs/SidebarUtils.ts index 0e8447635098..735011e455cd 100644 --- a/src/libs/SidebarUtils.ts +++ b/src/libs/SidebarUtils.ts @@ -129,10 +129,10 @@ function getOrderedReportIDs( return; } const isSystemChat = ReportUtils.isSystemChat(report); - const isSubmittedExpenseReportManagerWithoutParentAccess = ReportUtils.isSubmittedExpenseReportManagerWithoutParentAccess(report); + const isExpenseReportManagerWithoutParentAccess = ReportUtils.isExpenseReportManagerWithoutParentAccess(report); const shouldOverrideHidden = // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing - hasValidDraftComment(report.reportID) || hasErrorsOtherThanFailedReceipt || isFocused || isSystemChat || report.isPinned || isSubmittedExpenseReportManagerWithoutParentAccess; + hasValidDraftComment(report.reportID) || hasErrorsOtherThanFailedReceipt || isFocused || isSystemChat || report.isPinned || isExpenseReportManagerWithoutParentAccess; if (isHidden && !shouldOverrideHidden) { return; }