From 4005910f3736b67b9673c493a4728b1cac331d11 Mon Sep 17 00:00:00 2001 From: Sachin Chavda Date: Tue, 10 Sep 2024 01:23:16 +0530 Subject: [PATCH 1/3] Fixed Header of settings page --- src/pages/settings/InitialSettingsPage.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/pages/settings/InitialSettingsPage.tsx b/src/pages/settings/InitialSettingsPage.tsx index eeacd56f8d5c..bd084eefb38e 100755 --- a/src/pages/settings/InitialSettingsPage.tsx +++ b/src/pages/settings/InitialSettingsPage.tsx @@ -428,18 +428,19 @@ function InitialSettingsPage({userWallet, bankAccountList, fundList, walletTerms return ( + {headerContent} - {headerContent} {accountMenuItems} {workspaceMenuItems} {generalMenuItems} From 05e5ace37a8639577c60af2a3afe35fb92deb691 Mon Sep 17 00:00:00 2001 From: Sachin Chavda Date: Tue, 10 Sep 2024 02:07:07 +0530 Subject: [PATCH 2/3] prettier --- src/pages/settings/InitialSettingsPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/settings/InitialSettingsPage.tsx b/src/pages/settings/InitialSettingsPage.tsx index bd084eefb38e..38d80cf1e41d 100755 --- a/src/pages/settings/InitialSettingsPage.tsx +++ b/src/pages/settings/InitialSettingsPage.tsx @@ -439,7 +439,7 @@ function InitialSettingsPage({userWallet, bankAccountList, fundList, walletTerms onScroll={onScroll} scrollEventThrottle={16} contentContainerStyle={[styles.w100]} - showsVerticalScrollIndicator = {false} + showsVerticalScrollIndicator={false} > {accountMenuItems} {workspaceMenuItems} From 4127f28517c78460150cd33bbb57bfaf54baabe6 Mon Sep 17 00:00:00 2001 From: Sachin Chavda Date: Tue, 10 Sep 2024 21:12:53 +0530 Subject: [PATCH 3/3] chnaged header avatar size to default and fixed skeleton view to match new header style --- src/components/AccountSwitcher.tsx | 2 +- src/components/AccountSwitcherSkeletonView/index.tsx | 8 ++++---- src/pages/settings/InitialSettingsPage.tsx | 8 ++++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/components/AccountSwitcher.tsx b/src/components/AccountSwitcher.tsx index ba30ea0062b9..266bdd6fde2c 100644 --- a/src/components/AccountSwitcher.tsx +++ b/src/components/AccountSwitcher.tsx @@ -132,7 +132,7 @@ function AccountSwitcher() { ; }; -function AccountSwitcherSkeletonView({shouldAnimate = true, avatarSize = CONST.AVATAR_SIZE.LARGE}: AccountSwitcherSkeletonViewProps) { +function AccountSwitcherSkeletonView({shouldAnimate = true, avatarSize = CONST.AVATAR_SIZE.DEFAULT}: AccountSwitcherSkeletonViewProps) { const theme = useTheme(); const styles = useThemeStyles(); const StyleUtils = useStyleUtils(); @@ -30,7 +30,7 @@ function AccountSwitcherSkeletonView({shouldAnimate = true, avatarSize = CONST.A animate={shouldAnimate} backgroundColor={theme.skeletonLHNIn} foregroundColor={theme.skeletonLHNOut} - height={avatarPlaceholderSize + styles.pb3.paddingBottom} + height={avatarPlaceholderSize} > diff --git a/src/pages/settings/InitialSettingsPage.tsx b/src/pages/settings/InitialSettingsPage.tsx index 38d80cf1e41d..30f4cf010f70 100755 --- a/src/pages/settings/InitialSettingsPage.tsx +++ b/src/pages/settings/InitialSettingsPage.tsx @@ -370,11 +370,11 @@ function InitialSettingsPage({userWallet, bankAccountList, fundList, walletTerms const workspaceMenuItems = useMemo(() => getMenuItemsSection(workspaceMenuItemsData), [workspaceMenuItemsData, getMenuItemsSection]); const headerContent = ( - + {isEmptyObject(currentUserPersonalDetails) || currentUserPersonalDetails.displayName === undefined ? ( - + ) : ( - +