-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tooltip reappears #49913
fix: tooltip reappears #49913
Conversation
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daledah we should just dismiss the tooltip and not show it again
Screen.Recording.2024-09-30.at.7.30.51.AM.mov
@daledah any updates? |
@dukenv0307 I updated. |
@daledah perf tests are failing |
src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
Outdated
Show resolved
Hide resolved
src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
Outdated
Show resolved
Hide resolved
@dukenv0307 @luacmartins I think we can ignore the perf test since it compares the render times between this PR and main branch. In this PR we introduce |
We're introducing 9 new re-renders? Can we at least make that better? |
@daledah did you get a chance to look into my last comment? |
@luacmartins I'm testing for performance tests locally. Will update soon. |
@daledah any updates? |
@dukenv0307 I updated. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-09-26.at.10.57.42.movAndroid: mWeb ChromeScreen.Recording.2024-09-26.at.10.53.03.moviOS: NativeScreen.Recording.2024-09-26.at.10.56.02.moviOS: mWeb SafariScreen.Recording.2024-09-26.at.10.51.39.movMacOS: Chrome / SafariScreen.Recording.2024-10-09.at.10.13.46.movMacOS: DesktopScreen.Recording.2024-10-09.at.10.20.21.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.47-1 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀
|
Details
Fixed Issues
$ #49873
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-09-29.at.22.49.38.mov
Android: mWeb Chrome
Screen.Recording.2024-09-29.at.22.57.07.mov
iOS: Native
Screen.Recording.2024-09-29.at.23.02.43.mov
iOS: mWeb Safari
Screen.Recording.2024-09-29.at.23.05.11.mov
MacOS: Chrome / Safari
Screen.Recording.2024-09-30.at.15.20.11.mov
MacOS: Desktop
Screen.Recording.2024-09-30.at.15.28.26.mov