Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] chore(ci): remove fetch-depth param #50559

Merged
merged 3 commits into from
Dec 6, 2024
+0 −20
Merged

[NoQA] chore(ci): remove fetch-depth param #50559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30335e4
fix(ci): remove `fetch-depth` paramater
szymonrybczak Oct 10, 2024
57cbb28
fix: remove trigger action comment
szymonrybczak Oct 10, 2024
64296b5
Merge branch 'main' into szymonrybczak/chore/remove-fetch-depth-param
szymonrybczak Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/workflows/reassurePerformanceTests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup NodeJS
uses: ./.github/actions/composite/setupNode
Expand All @@ -24,22 +22,6 @@ jobs:
git config --global user.email "test@test.com"
git config --global user.name "Test"

- name: Get common ancestor commit
run: |
git fetch origin main
common_ancestor=$(git merge-base "${{ github.sha }}" origin/main)
echo "COMMIT_HASH=$common_ancestor" >> "$GITHUB_ENV"

- name: Clean up deleted files
run: |
DELETED_FILES=$(git diff --name-only --diff-filter=D "$COMMIT_HASH" "${{ github.sha }}")
for file in $DELETED_FILES; do
if [ -n "$file" ]; then
rm -f "$file"
echo "Deleted file: $file"
fi
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we need this deletion logic before but don't need it now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic was originally added to resolve an issue where files weren’t properly deleted on CI, causing Reassure tests to fail by detecting duplicate files with the same tests. The issue occurred during the migration to TypeScript when test file names were changed. Now that the migration is complete, we no longer need this logic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need this. We are facing an issue where after a patch file is renamed the instance sees two patches and patch-package fail https://github.com/Expensify/App/actions/runs/12285318556/job/34283030276?pr=53627


- name: Run performance testing script
shell: bash
run: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/sendReassurePerfData.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Setup NodeJS
uses: ./.github/actions/composite/setupNode
Expand Down
Loading