-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show two creation options at the same time in the workspace switcher #52254
Conversation
@brunovjk , I am getting 429 on new signup currently, i will update videos in sometime: |
Great :D Thank you. When everything is ready, let me know and I'll test it. |
thanks for the patience, the PR is ready for your review @brunovjk |
Reviewer Checklist
Screenshots/VideosAndroid: Native52254_android_web.movAndroid: mWeb Chrome52254_android_web.moviOS: Native52254_ios_native.moviOS: mWeb Safari52254_ios_web.movMacOS: Desktop52254_web_desktop.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One detail, not related to this PR, the expected behavior, mentioned here:
There is a different "copy" than the current:
Can anyone tell me if this is on purpose? Especially these double --
.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.60-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀
|
Explanation of Change
When we prompt users to create a new workspace in the workspace switcher, they become confused by two options that do the same thing, which leads to frustration.
So we hide the plus icon if no workspace exists
Fixed Issues
$ #52030
PROPOSAL: #52030 (comment)
Tests
Verify that there is no
Plus
icon when there are no workspaces present.Offline tests
N/A
QA Steps
Verify that there is no
Plus
icon when there are no workspaces present.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-09.at.5.37.27.PM.mov
Android: mWeb Chrome
Screen.Recording.2024-11-09.at.5.39.02.PM.mov
iOS: Native
Screen.Recording.2024-11-09.at.5.41.12.PM.mov
iOS: mWeb Safari
Screen.Recording.2024-11-09.at.5.42.04.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-11-09.at.5.23.45.PM.mov
MacOS: Desktop
Screen.Recording.2024-11-09.at.5.27.48.PM.mov