-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA][ADHOC builds] Add a comment when the build begins #52587
Conversation
@mountiny @Julesssss, you often use test builds. WDYT about adding a comment to the PR when the builds begin? |
I like this, could we also include link to the run? that would be even more useful. |
Yeah, this (and Vit's suggestion) sound good |
Sweet thanks @mountiny @Julesssss, I added a link to the workflow URL. I'm just trying to sort how (or if?) I can test this locally |
@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🚧 @grgia has triggered a test build. You can view the workflow run here. |
The Github CLI makes it surprisingly easy to test workflows from your local machine. But I think it's also fine to just test this once the next action occurs |
@Julesssss I tried running it from this branch, which worked! TDIL |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Ah nice. Feel free to merge ✅ |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/grgia in version: 9.0.63-1 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.63-3 🚀
|
Explanation of Change
I often use test builds and thought it would be useful to add a comment to the PR for reviewers to be alerted when the build begins.
Fixed Issues
$ #52613
Tests
Navigate to the Workflow Page
Go to the workflow page.
Change the Workflow to Reference the Current Branch
Update the workflow settings to reference this branch:
Verify the Comment with Correct Information
Confirm that the appropriate comment has been added with the correct information:
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop