Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732

QichenZhu · 2024-11-18T22:58:29Z

Explanation of Change

Fixed Issues

$ #52496
PROPOSAL: #52496 (comment)

Tests

Tap FAB > Start chat.
Go back by swiping or using the back button.
Repeat the above steps 10 times or until the app crashes, whichever comes first. The test passes if the app doesn't crash, and fails if it does.

Verify that no errors appear in the JS console

Offline tests

Tap FAB > Start chat.
Go back by swiping or using the back button.
Repeat the above steps 10 times or until the app crashes, whichever comes first. The test passes if the app doesn't crash, and fails if it does.

QA Steps

Tap FAB > Start chat.
Go back by swiping or using the back button.
Repeat the above steps 10 times or until the app crashes, whichever comes first. The test passes if the app doesn't crash, and fails if it does.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mp4

MacOS: Desktop

mac-desktop.mp4

…d feature flag

melvin-bot · 2024-11-19T04:03:01Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2024-11-19T09:49:03Z

patches/react-native+0.75.2+021+allow-recursive-commits-with-synchronous-mount-on-android.patch

+  // if (ReactNativeFeatureFlags::
+  //         allowRecursiveCommitsWithSynchronousMountOnAndroid()) {


I think return true in allowRecursiveCommitsWithSynchronousMountOnAndroid declaration inside ReactNativeFeatureFlags file is better. WDYT?

The default value seems to be defined in four places, and this is the only place that reads this flag, so patching it here is easier. I'm also fine with changing the four default values. Do you prefer that?

https://github.com/facebook/react-native/blob/2e994fdddb05955ee8dcce1e2151288977dd1c5e/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt#L30

https://github.com/facebook/react-native/blob/d1c72016c12b552b1140652209fb816a9facf0f2/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h#L39

https://github.com/facebook/react-native/blob/d1c72016c12b552b1140652209fb816a9facf0f2/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js#L48

https://github.com/facebook/react-native/blob/d1c72016c12b552b1140652209fb816a9facf0f2/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js#L117

Hmm! Ok, keep it as it is.

I think no need for comments in L11, L12 and L13, We can remove it.

ahmedGaber93 · 2024-11-20T13:08:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

20241120050440152.mp4

Android: mWeb Chrome

20241120051308448.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ahmedGaber93

LGTM!

github-actions · 2024-11-20T14:17:36Z

🚧 @rlinoz has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-20T14:46:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52732/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/52732/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52732/NewExpensify.dmg	https://52732.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

rlinoz

Seems to work very well, thanks!

OSBotify · 2024-11-20T15:34:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-21T01:45:17Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-22T19:49:20Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroi…

c6ca14f

…d feature flag

QichenZhu marked this pull request as ready for review November 19, 2024 04:02

QichenZhu requested a review from a team as a code owner November 19, 2024 04:02

melvin-bot bot requested a review from ahmedGaber93 November 19, 2024 04:03

melvin-bot bot removed the request for review from a team November 19, 2024 04:03

QichenZhu marked this pull request as draft November 19, 2024 04:12

QichenZhu marked this pull request as ready for review November 19, 2024 04:19

ahmedGaber93 reviewed Nov 19, 2024

View reviewed changes

Remove comments

fa8281f

ahmedGaber93 approved these changes Nov 20, 2024

View reviewed changes

melvin-bot bot requested a review from rlinoz November 20, 2024 13:14

rlinoz added the Ready To Build label Nov 20, 2024

rlinoz approved these changes Nov 20, 2024

View reviewed changes

rlinoz merged commit 5df79da into Expensify:main Nov 20, 2024
9 of 10 checks passed

github-actions bot mentioned this pull request Nov 21, 2024

Deploy Checklist: New Expensify 2024-11-21 #52862

Closed

65 tasks

melvin-bot bot mentioned this pull request Nov 22, 2024

[HOLD for payment 2024-11-29] [$250] Android - App crashes when create new chat #52496

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732

Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732

QichenZhu commented Nov 18, 2024 •

edited

Loading

melvin-bot bot commented Nov 19, 2024

ahmedGaber93 Nov 19, 2024 •

edited

Loading

QichenZhu Nov 19, 2024

ahmedGaber93 Nov 19, 2024

ahmedGaber93 Nov 19, 2024 •

edited

Loading

QichenZhu Nov 19, 2024

ahmedGaber93 commented Nov 20, 2024 •

edited

Loading

ahmedGaber93 left a comment

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

rlinoz left a comment

OSBotify commented Nov 20, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

		+ // if (ReactNativeFeatureFlags::
		+ // allowRecursiveCommitsWithSynchronousMountOnAndroid()) {

Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732

Add patch to enable allowRecursiveCommitsWithSynchronousMountOnAndroid feature flag #52732

Conversation

QichenZhu commented Nov 18, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 19, 2024

ahmedGaber93 Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

QichenZhu Nov 19, 2024

Choose a reason for hiding this comment

ahmedGaber93 Nov 19, 2024

Choose a reason for hiding this comment

ahmedGaber93 Nov 19, 2024 • edited Loading

Choose a reason for hiding this comment

QichenZhu Nov 19, 2024

Choose a reason for hiding this comment

ahmedGaber93 commented Nov 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ahmedGaber93 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

rlinoz left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 20, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

QichenZhu commented Nov 18, 2024 •

edited

Loading

ahmedGaber93 Nov 19, 2024 •

edited

Loading

ahmedGaber93 Nov 19, 2024 •

edited

Loading

ahmedGaber93 commented Nov 20, 2024 •

edited

Loading