PATCH: Android - Fix caret resetting to the beginning of the input #52734

ikevin127 · 2024-11-19T01:54:28Z

Explanation of Change

We're applying a patch which includes two react-native fixes (1) and (2) which were merged but will take some time to reach production. The patch is fixing an issue based in the Android native code which caused the selection caret to be reset to the beginning of the input instead at the end when the input is not empty. More details in the issue / proposal.

Fixed Issues

$ #52029
$ #50055
PROPOSAL: #52029 (comment)

Tests

Note

This PR fix only applies to Android: Native, none of the other platforms will be affected or work differently.

Precondition: Make sure to perform a clean install of node_modules and ensure the new patch is applied.

Steps for issue #52029:

Launch Android: Native app.
Login with account with expensify card enabled with bank account added, and few members invited in workspace.
Go to workspace settings.
Tap expensify card.
Tap issue card.
Select a user -> physical card -> monthly.
Input an amount in the Set a limit amount page.
Go to confirmation page.
Navigate back to the Set a limit amount page.
Verify that the cursor caret is at the end of amount, not at the begginning right after the currency symbol.

Steps for issue #50055:

Launch Android: Native app.
Log in with new account.
Go to Settings -> New workspace - More features - enable invoice.
Navigate to LHN.
Tap FAB -> Send invoice.
Enter an amount and tap Next.
Select a user.
Tap Next.
Enter company name and address.
Tap Send invoice.
Open invoice -> tap on Amount field.
Reopen the Amount field (repeat step 11).
Verify that the cursor caret is at the end of the amount, not at the begginning right after the currency symbol.

Verify that no errors appear in the JS console

Offline tests

N/A.

QA Steps

Note

This PR fix only applies to Android: Native, none of the other platforms will be affected or work differently.

Steps for issue #52029:

Launch Android: Native app.
Login with account with expensify card enabled with bank account added, and few members invited in workspace.
Go to workspace settings.
Tap expensify card.
Tap issue card.
Select a user -> physical card -> monthly.
Input an amount in the Set a limit amount page.
Go to confirmation page.
Navigate back to the Set a limit amount page.
Verify that the cursor caret is at the end of the amount, not at the begginning right after the currency symbol.

Steps for issue #50055:

Launch Android: Native app.
Log in with new account.
Go to Settings -> New workspace - More features - enable invoice.
Navigate to LHN.
Tap FAB -> Send invoice.
Enter an amount and tap Next.
Select a user.
Tap Next.
Enter company name and address.
Tap Send invoice.
Open invoice -> tap on Amount field.
Reopen the Amount field (repeat step 11).
Verify that the cursor caret is at the end of the amount, not at the begginning right after the currency symbol.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Note

This PR fix only applies to Android: Native, none of the other platforms will be affected or work differently.

Card Limit Amount Issue	Invoice Amount Issue
android-card-limit.webm	android-invoice-amount.webm

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-11-19T01:54:33Z

@shawnborton @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-11-19T04:10:36Z

Reviewing

shawnborton · 2024-11-19T10:24:14Z

Videos look pretty good to me 👍

shawnborton · 2024-11-19T10:25:57Z

It does look like there is a slight delay once the cursor is shown right after the currency amount and then the cursor goes to the end of the input when the amount shows up. I'm not sure exactly what to make of that, maybe that's just an artifact of using RN here. cc @Expensify/design for input, and Jon curious if this is something that feels common across Android devices.

To be clear, this is a huge improvement from what we had before so I'm happy to move forward with what is shown here.

ikevin127 · 2024-11-19T10:56:32Z

Note: The videos were taken on Android emulator which is pretty slow UI / UX wise compared to real Android devices. I will perform a build of this on my OnePlus 7T running Android 14 tomorrow to show how it looks on an actual device 🙌

Edit: I tested on real device and there's no difference in this case.

It does look like there is a slight delay once the cursor is shown right after the currency amount and then the cursor goes to the end of the input when the amount shows up.

I think this comes from the fact that the amount input's width is dynamic (grows with the input) which causes that glitchy effect on mount:

App/src/components/AmountTextInput.tsx

Lines 61 to 63 in a1196a6

    
           return ( 
        
               <TextInput 
        
                   autoGrow

To be clear, this is a huge improvement from what we had before so I'm happy to move forward with what is shown here.

From my side we're good to go move forward here with merging the PR.

dubielzyk-expensify · 2024-11-20T01:11:36Z

I'm not sure exactly what to make of that, maybe that's just an artifact of using RN here. cc @Expensify/design for input, and Jon curious if this is something that feels common across Android devices.

Nothing I've come across, but agree that it looks like a slow device/RN artefact. I would say we're still likely to see this on real devices though given lots of people out there don't have the newest technology. But still this feels a lot better so I'm okay with it too.

mananjadhav · 2024-11-20T06:29:47Z

Left with the final testing, will finish the checklist today.

github-actions · 2024-11-20T10:40:20Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

mountiny · 2024-11-20T10:58:04Z

Chatted with @hannojg and I believe the issue with the glitchy cursor should be fixed with this PR hopefully #50238

github-actions · 2024-11-20T11:07:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52734/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/52734/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52734/NewExpensify.dmg	https://52734.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-11-20T11:28:34Z

@mananjadhav what is your ETA for the checklist?

mananjadhav · 2024-11-20T12:23:17Z

I have been trying to run the build locally and it's failing. I just finished a checklist for another PR and I didn't have the issue. Will delete all node_modules again and update the checklist in max few hours.

mananjadhav · 2024-11-20T16:37:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-send-invoice-amount-caret.mp4

android-card-limt-amount-caret.mp4

Android: mWeb Chrome

mweb-chrome-amount-caret.mov

iOS: Native

ios-card-amount-caret.mov

iOS: mWeb Safari

mweb-safari-amount-caret.mov

MacOS: Chrome / Safari

MacOS: Desktop

shawnborton · 2024-11-20T22:41:22Z

All good on my end, feel free to merge 👍

OSBotify · 2024-11-20T23:11:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-21T01:45:20Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-22T19:49:23Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

FIX: Android - Caret resets to the beginning of the input

98335d1

ikevin127 requested a review from a team as a code owner November 19, 2024 01:54

melvin-bot bot requested review from mananjadhav and shawnborton November 19, 2024 01:54

melvin-bot bot removed the request for review from a team November 19, 2024 01:54

ikevin127 mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-11-29] [$375] Card - Android - when user goes back to amount step in the flow the cursor is at the beginning instead of the end of the amount #52029

Open

8 tasks

mollfpr mentioned this pull request Nov 19, 2024

[HOLD] [$250] Android Hybrid - Login - Cursor displayed at the beggining of Email when trying to re login #51878

Closed

8 tasks

mountiny assigned ikevin127 Nov 20, 2024

mountiny added the Ready To Build label Nov 20, 2024

mananjadhav approved these changes Nov 20, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify November 20, 2024 17:02

aldo-expensify approved these changes Nov 20, 2024

View reviewed changes

shawnborton approved these changes Nov 20, 2024

View reviewed changes

aldo-expensify merged commit d49d52d into Expensify:main Nov 20, 2024
10 checks passed

github-actions bot mentioned this pull request Nov 21, 2024

Deploy Checklist: New Expensify 2024-11-21 #52862

Closed

65 tasks

melvin-bot bot mentioned this pull request Nov 22, 2024

[HOLD for payment 2024-11-29] [HOLD RN Upgrade] Android - Invoice - In invoice details page, reopening amount field shows cursor at beginning #50055

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PATCH: Android - Fix caret resetting to the beginning of the input #52734

PATCH: Android - Fix caret resetting to the beginning of the input #52734

ikevin127 commented Nov 19, 2024

melvin-bot bot commented Nov 19, 2024

mananjadhav commented Nov 19, 2024

shawnborton commented Nov 19, 2024

shawnborton commented Nov 19, 2024

ikevin127 commented Nov 19, 2024 •

edited

Loading

dubielzyk-expensify commented Nov 20, 2024

mananjadhav commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

mountiny commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

mountiny commented Nov 20, 2024

mananjadhav commented Nov 20, 2024

mananjadhav commented Nov 20, 2024 •

edited

Loading

shawnborton commented Nov 20, 2024

OSBotify commented Nov 20, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

PATCH: Android - Fix caret resetting to the beginning of the input #52734

PATCH: Android - Fix caret resetting to the beginning of the input #52734

Conversation

ikevin127 commented Nov 19, 2024

Explanation of Change

Fixed Issues

Tests

Steps for issue #52029:

Steps for issue #50055:

Offline tests

QA Steps

Steps for issue #52029:

Steps for issue #50055:

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 19, 2024

mananjadhav commented Nov 19, 2024

shawnborton commented Nov 19, 2024

shawnborton commented Nov 19, 2024

ikevin127 commented Nov 19, 2024 • edited Loading

dubielzyk-expensify commented Nov 20, 2024

mananjadhav commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

mountiny commented Nov 20, 2024

github-actions bot commented Nov 20, 2024

mountiny commented Nov 20, 2024

mananjadhav commented Nov 20, 2024

mananjadhav commented Nov 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

shawnborton commented Nov 20, 2024

OSBotify commented Nov 20, 2024

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

ikevin127 commented Nov 19, 2024 •

edited

Loading

mananjadhav commented Nov 20, 2024 •

edited

Loading