-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invoice thread isn't deleted when dismissing create error #54232
Fix invoice thread isn't deleted when dismissing create error #54232
Conversation
@bernhardoj please merge |
…dismissing-create-error
@paultsimura thanks for the info! |
Oh, it somehow triggers the lint on an unchanged file. Also, I think it's a false positive on the IOUTest file |
@VickyStash WDYT? |
IMO, it should be super easy to fix |
Please, merge the latest main to your branch.
I've checked locally and it seems to be okay. |
Reviewer Checklist
Screenshots/VideosAndroid: Native54232.Android.mp4Android: mWeb Chrome54232.mWeb-Chrome.mp4iOS: Native54232.iOS.moviOS: mWeb Safari54232.mWeb-Safari.movMacOS: Chrome / Safari54232.Web.mp4MacOS: Desktop54232.Desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explanation of Change
Fixed Issues
$ #54035
PROPOSAL: #54035 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
https://google.com
)PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4