Migrate AuthScreens to useOnyx v2 #55966

WojtekBoman · 2025-01-29T15:58:54Z

Explanation of Change

This PR replaces withOnyx with useOnyx in AuthScreens and fixes the issue caused by the previous migration PR.

Fixed Issues

$ #49103
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Verify that the login flow works the same as before the migration.
Verify whether opening reports works the same as before the migration.
Verify if this issue doesn't occur anymore.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Verify that the login flow works the same as before the migration.
Verify whether opening reports works the same as before the migration.
Verify if this issue doesn't occur anymore.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-02-17.at.14.08.33.mov

Android: mWeb Chrome

Screen.Recording.2025-02-17.at.14.20.14.mov

iOS: Native

Screen.Recording.2025-02-17.at.15.39.19.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-02-17.at.13.58.27.mp4

MacOS: Desktop

Screen.Recording.2025-02-17.at.13.47.18.mp4

Screen.Recording.2025-02-17.at.13.45.01.mp4

…on/index

melvin-bot · 2025-02-17T15:00:13Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2025-02-19T15:25:18Z

@c3024 What's your ETA on review?

c3024 · 2025-02-19T15:27:28Z

I'm on it. It should be finished in an hour.

c3024 · 2025-02-19T15:54:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

migrateAndroid.mov

Android: mWeb Chrome

migrateAndroidmWeb.mov

iOS: Native

migrateiOS.mov

iOS: mWeb Safari

migrateiOSmWeb.mov

MacOS: Chrome / Safari

migrateChrome.mov

MacOS: Desktop

migrateDesktop1.mov

migrateDesktop2.mov

c3024

LGTM!

deetergp · 2025-02-21T00:53:38Z

Friendly bump @MonilBhavsar

blazejkustra · 2025-02-21T13:49:06Z

@WojtekBoman will be OOO next week, so in case of any blockers please ping me 🙏 (I hope it won't be necessary hahah)

github-actions · 2025-02-24T20:14:38Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.5-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

…/auth-screens-2" This reverts commit 5bf5684, reversing changes made to c344aea.

Revert #55966 / Fix "just sign in here" Magic Code page link

Revert #55966 / Fix "just sign in here" Magic Code page link (cherry picked from commit 7628627) (CP triggered by chiragsalian)

github-actions · 2025-02-26T00:03:45Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.5-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-26T00:22:31Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-26T10:42:51Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.1.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-26T22:40:10Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.6-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

WojtekBoman mentioned this pull request Jan 29, 2025

[Due for payment 2025-03-05] [Due for payment 2025-03-05] [$100] Migrate AuthScreens to useOnyx #49103

Open

blazejkustra approved these changes Jan 30, 2025

View reviewed changes

ahmedGaber93 mentioned this pull request Feb 5, 2025

[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Desktop - App auto relogins after signing out #55681

Closed

8 tasks

WojtekBoman force-pushed the use-onyx/auth-screens-2 branch from 02eb7e1 to 199a93d Compare February 12, 2025 16:25

WojtekBoman added 3 commits February 17, 2025 13:29

Migrate AuthScreens to useOnyx

50a379f

Fix lint in Session/index.ts

54f6a95

Rename resetHomeRouteParams function to resetNavigationState in Sessi…

433d686

…on/index

WojtekBoman force-pushed the use-onyx/auth-screens-2 branch from 199a93d to 433d686 Compare February 17, 2025 14:42

WojtekBoman changed the title ~~Migrate AuthScreens to useOnyx~~ Migrate AuthScreens to useOnyx v2 Feb 17, 2025

WojtekBoman marked this pull request as ready for review February 17, 2025 15:00

WojtekBoman requested a review from a team as a code owner February 17, 2025 15:00

melvin-bot bot requested a review from c3024 February 17, 2025 15:00

melvin-bot bot removed the request for review from a team February 17, 2025 15:00

c3024 approved these changes Feb 19, 2025

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar February 19, 2025 15:56

deetergp approved these changes Feb 19, 2025

View reviewed changes

deetergp merged commit 5bf5684 into Expensify:main Feb 24, 2025
17 of 20 checks passed

github-actions bot mentioned this pull request Feb 24, 2025

Deploy Checklist: New Expensify 2025-02-24 #57336

Closed

52 tasks

francoisl added a commit that referenced this pull request Feb 25, 2025

Revert "Merge pull request #55966 from software-mansion-labs/use-onyx…

b56ba8f

…/auth-screens-2" This reverts commit 5bf5684, reversing changes made to c344aea.

This was referenced Feb 25, 2025

[CP Staging] Revert #55966 / Fix "just sign in here" Magic Code page link #57362

Merged

[Due for payment 2025-03-05] [Due for payment 2025-03-05] Sign in - Blank page opens after clicking "Sign In here" when signing in in different session #57359

Closed

srikarparsi added a commit that referenced this pull request Feb 25, 2025

Merge pull request #57362 from Expensify/francois-revert-55966

7628627

Revert #55966 / Fix "just sign in here" Magic Code page link

OSBotify pushed a commit that referenced this pull request Feb 25, 2025

Merge pull request #57362 from Expensify/francois-revert-55966

ccea23c

Revert #55966 / Fix "just sign in here" Magic Code page link (cherry picked from commit 7628627) (CP triggered by chiragsalian)

github-actions bot mentioned this pull request Feb 25, 2025

Deploy Checklist: New Expensify 2025-02-25 #57435

Closed

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate AuthScreens to useOnyx v2 #55966

Migrate AuthScreens to useOnyx v2 #55966

WojtekBoman commented Jan 29, 2025 •

edited

Loading

melvin-bot bot commented Feb 17, 2025

blazejkustra commented Feb 19, 2025

c3024 commented Feb 19, 2025

c3024 commented Feb 19, 2025 •

edited

Loading

c3024 left a comment

deetergp commented Feb 21, 2025

blazejkustra commented Feb 21, 2025

github-actions bot commented Feb 24, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

Migrate AuthScreens to useOnyx v2 #55966

Migrate AuthScreens to useOnyx v2 #55966

Conversation

WojtekBoman commented Jan 29, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 17, 2025

blazejkustra commented Feb 19, 2025

c3024 commented Feb 19, 2025

c3024 commented Feb 19, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

deetergp commented Feb 21, 2025

blazejkustra commented Feb 21, 2025

github-actions bot commented Feb 24, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

WojtekBoman commented Jan 29, 2025 •

edited

Loading

c3024 commented Feb 19, 2025 •

edited

Loading