Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strikethrough replace rule to fix multiple tilde error #569

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Update strikethrough replace rule to fix multiple tilde error #569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60288ce
update strikethrough replace rule
akamefi202 Aug 31, 2023
b25dcc5
revert package-lock.json
akamefi202 Aug 31, 2023
7227665
revert package-lock.json1
akamefi202 Aug 31, 2023
4d00893
test update
akamefi202 Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions __tests__/ExpensiMark-HTML-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,3 +1225,11 @@ test('Test link with code fence inside the alias text part', () => {
+ '[test <pre>code</pre> test](<a href="https://google.com" target="_blank" rel="noreferrer noopener">google.com</a>)';
expect(parser.replace(testString)).toBe(resultString);
});

test('Test strikethrough with multiple tilde characters', () => {
let testString = '~~~hello~~~';
expect(parser.replace(testString)).toBe('~~<del>hello</del>~~');

testString = '~~~~';
expect(parser.replace(testString)).toBe('~~~~');
});
2 changes: 1 addition & 1 deletion lib/ExpensiMark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ export default class ExpensiMark {
},
{
name: 'strikethrough',
regex: /\B~((?=\S)((~~(?!~)|[^\s~]|\s(?!~))+?))~\B(?![^<]*(<\/pre>|<\/code>|<\/a>))/g,
regex: /\B~((?=\S)(([^\s~]|\s(?!~))+?))~\B(?![^<]*(<\/pre>|<\/code>|<\/a>))/g,
replacement: (match, g1) => (this.containsNonPairTag(g1) ? match : `<del>${g1}</del>`),
},
{
Expand Down
Loading