End the url at the first unmatched closing parenthesis #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…url at the first one we encounter Signed-off-by: Pierre Michel <pmiche04@gmail.com>
Signed-off-by: Pierre Michel <pmiche04@gmail.com>
melvin-bot
bot
requested review from
neil-marcellini
and removed request for
a team
6 tasks
neil-marcellini
requested review from
cead22
and removed request for
neil-marcellini
|
@cead22 I'm going to let you take this one since you're the assigned engineer on the issue. |
cead22
requested changes
Sep 22, 2023
Signed-off-by: Pierre Michel <pmiche04@gmail.com>
|
@cead22 I made the changes |
cead22
previously approved these changes
Sep 26, 2023
|
@ShogunFire lint errors |
Signed-off-by: Pierre Michel <pmiche04@gmail.com>
|
They should be fixed now but I can't verify because it doesn't launch the test |
cead22
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robertKozik @cead22
We end the url at the first unmatched parenthesis because it is unlikely that this closing parenthesis is part of the url and it can be part of the markdown for example
Fixed Issues
$ Expensify/App#26788
Tests
google.com/(toto))titi)google.com/(toto)QA
Same tests and test urls and markdown in general
Video
2023-09-19.09-28-20.mp4