Issue-26016 make usermention case insensitive #591
Conversation
melvin-bot
bot
requested review from
srikarparsi
and removed request for
a team
|
@sobitneupane would you please comment here so I can assign you for review? @nikhildewoolkar please link the fixed issue properly next time so that auto assignment runs. |
| let testString = '@user@domain.com'; | ||
| expect(parser.replace(testString)).toBe('<mention-user>@user@domain.com</mention-user>'); | ||
|
|
||
| testString = '@USER@DOMAIN.COM'; | ||
| expect(parser.replace(testString)).toBe('<mention-user>@user@domain.com</mention-user>'); | ||
|
|
||
| testString = '@USER@domain.com'; | ||
| expect(parser.replace(testString)).toBe('<mention-user>@user@domain.com</mention-user>'); | ||
|
|
||
| testString = '@user@DOMAIN.com'; | ||
| expect(parser.replace(testString)).toBe('<mention-user>@user@domain.com</mention-user>'); | ||
|
|
||
| testString = '@user@domain.com'; | ||
| expect(parser.replace('<mention-user>@user@domain.com</mention-user>')).toBe(testString); | ||
|
|
||
| testString = '@USER@DOMAIN.COM'; | ||
| expect(parser.replace('<mention-user>@USER@DOMAIN.COM</mention-user>')).toBe(testString); | ||
|
|
||
| testString = '@USER@domain.com'; | ||
| expect(parser.replace('<mention-user>@USER@domain.com</mention-user>')).toBe(testString); | ||
|
|
||
| testString = '@user@DOMAIN.com'; | ||
| expect(parser.replace('<mention-user>@user@DOMAIN.com</mention-user>')).toBe(testString); |
There was a problem hiding this comment.
Only test htmlToMarkdown with that method
There was a problem hiding this comment.
@nikhildewoolkar
We do have test for user mention in "ExpensiMark-HTML-test.js"
expensify-common/__tests__/ExpensiMark-HTML-test.js
Lines 1103 to 1107 in 82bfcd1
You can add other similar tests with capital letters in username and domain in testString.
We do not have tests for html to text for <mention-user> as of now. You can add those tests in "/ExpensiMark-HTMLToText-test.js" file. Please go through existing tests in the file and add new tests accordingly.
|
Kindly review PR. I have made requested changes. |
Fixed Issues
$ GH_LINK
Expensify/App#26016
Tests
Open the app
Open any report
Write '@' to trigger mentions
Select any one mention, make any letter of mention as capital and send
Hover on mention to observe that tooltip doesn't display the right display name and avatar
For same mention as step 4 or select different mention and capitalize all letters and send
Observe that now it is not displayed as mention