rewrite LOOSE_URL_WEBSITE_REGEX #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
AndrewGable
and removed request for
a team
AndrewGable
requested review from
dangrous
and removed request for
AndrewGable
dangrous
approved these changes
Dec 3, 2024
|
@ntdiary can you take a look at this one? I can't assign you as a reviewer on GH since it's |
dangrous
approved these changes
Dec 4, 2024
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite is needed for better performance as the previous regex caused too many backtracks that hermes was not able to handle
Fixed Issues
$ Expensify/App#52475
Tests
Existing tests are enough
QA
None