-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump expensify-common to 2.0.108 #557
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for CIs.
@@ -100,7 +100,7 @@ | |||
"typescript": "~5.3.3" | |||
}, | |||
"peerDependencies": { | |||
"expensify-common": ">=2.0.106", | |||
"expensify-common": ">=2.0.108", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to bump this in my opinion, but if you do bump this, please also update README.md accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
cc @dangrous @ntdiary
Details
bump expensify-common to 2.0.108 to include a more performant regex Expensify/expensify-common#822
Related Issues
Expensify/App#52475
Manual Tests
![test](https://camo.githubusercontent.com/4848d0f965f332077b77a1a0488c3e66b4769032104f4de6890bae218b4add8d/68747470733a2f2f70696373756d2e70686f746f732f69642f313036372f3230302f333030 )_test
Linked PRs