Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump expensify-common to 2.0.108 #557

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

s77rt
Copy link
Contributor

@s77rt s77rt commented Dec 4, 2024

cc @dangrous @ntdiary

Details

bump expensify-common to 2.0.108 to include a more performant regex Expensify/expensify-common#822

Related Issues

Expensify/App#52475

Manual Tests

  1. Type ![test](https://camo.githubusercontent.com/4848d0f965f332077b77a1a0488c3e66b4769032104f4de6890bae218b4add8d/68747470733a2f2f70696373756d2e70686f746f732f69642f313036372f3230302f333030 )_test
  2. Verify the app doesn't crash

Linked PRs

Copy link

github-actions bot commented Dec 4, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@s77rt
Copy link
Contributor Author

s77rt commented Dec 4, 2024

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Dec 4, 2024
@tomekzaw tomekzaw self-requested a review December 4, 2024 17:13
tomekzaw
tomekzaw previously approved these changes Dec 4, 2024
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for CIs.

@@ -100,7 +100,7 @@
"typescript": "~5.3.3"
},
"peerDependencies": {
"expensify-common": ">=2.0.106",
"expensify-common": ">=2.0.108",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump this in my opinion, but if you do bump this, please also update README.md accordingly.

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@tomekzaw tomekzaw merged commit 3c17bf4 into Expensify:main Dec 5, 2024
7 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented Dec 5, 2024

🚀 Published to npm in 0.1.192 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants