-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@swm/add draggable list #7
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
cab2dcc
to
19e0b88
Compare
@kosmydel Today, Expensify is internally decided not to create additional libraries if not needed. How much functionality did you implement (or rather exposed) in this library? If we're just exposing just the functionality used in NewDot, then it might be better to move the code over to NewDot to make things easier. Let me know what you think 🙇 |
@hayata-suenaga My implementation: I focused on exposing the functionality the NewDot app needed. There are also some extras like decorators. Of course, we can move this code to the NewDot app. Since this was mainly the wrapper, it might work. Please let me know about the next steps. |
Let's move the code over to App. I think we don't want to deal with the effort to maintain another library 🙇 There are also some extras like decorators. could you tell me what decorators do? do we need them in App? |
Sure, I am going to prepare PR for that. As I have internal training until Friday, my availability will be limited.
Those decorators work only on native, and 'decorate' items that are currently dragged (e.g. by scaling the item up a little bit or changing the opacity). |
Closing in favor of Expensify/App#26307 |
Details
This PR adds support for both draggable lists on both web (using react-beautiful-dnd and native (using react-native-draggable-flatlist).
Related Issues
Expensify/App#22716
Expensify/App#25740
Manual Tests
Linked PRs