Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physical external interface mapping always get tagged interface setting #1066

Open
myf5 opened this issue Oct 29, 2017 · 0 comments
Open

physical external interface mapping always get tagged interface setting #1066

myf5 opened this issue Oct 29, 2017 · 0 comments
Assignees
Labels

Comments

@myf5
Copy link

myf5 commented Oct 29, 2017

Set physical mapping as :
f5_external_physical_mappings = default:1.1:False,vlannet:1.2:False

Found the vlan created for "vlannet" always be tagged interface. This was found when test openstack lbaas v1. Found the issue was caused by permanent true logic in the below code. After checking V2 code, seem like same logic issue.

` def _assure_device_network_vlan(self, network, bigip, network_folder):
# Ensure bigip has configured tagged vlan
# VLAN names are limited to 64 characters including
# the folder name, so we name them foolish things.
vlan_name = ""
interface = self.interface_mapping['default']
tagged = self.tagging_mapping['default']

    # Do we have host specific mappings?
    net_key = network['provider:physical_network']
    if net_key and net_key + ':' + bigip.hostname in \
            self.interface_mapping:
        interface = self.interface_mapping[
            net_key + ':' + bigip.hostname]
        tagged = self.tagging_mapping[
            net_key + ':' + bigip.hostname]
    # Do we have a mapping for this network
    elif net_key and net_key in self.interface_mapping:
        interface = self.interface_mapping[net_key]
        tagged = self.tagging_mapping[net_key]

    if tagged: <<<<<<<<<<<!!!!!!!!
        vlanid = network['provider:segmentation_id']
    else:
        vlanid = 0`
@dflanigan dflanigan changed the title [bug]physical external interface mapping always get tagged interface setting physical external interface mapping always get tagged interface setting Nov 2, 2017
@dflanigan dflanigan added the bug label Nov 2, 2017
@dflanigan dflanigan assigned dflanigan and ssorenso and unassigned dflanigan Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants