Provide IPv6 mask for IPv6 virtual servers. #1295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VIP netmask was always given as 255.255.255.255 which caused errors when placing a Neutron LB on an IPv6 subnet. This passes the proper /128 mask for IPv6 virtual server IP addresses.
|
Can somebody re-run the CI for this commit? I don't see any failures related to the changed code. |
|
Bump. |
|
Closing this PR as it is 3 years old now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VIP netmask was always given as 255.255.255.255 which caused errors
when placing a Neutron LB on an IPv6 subnet. This passes the proper /128
mask for IPv6 virtual server IP addresses.
@richbrowne
What issues does this address?
Fixes #1294
...
What's this change do?
This change causes the agent to pass "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff" as the netmask for IPv6 VIPs rather than the previous value of 255.255.255.255. I did not do testing with IPv6 pool members.
Where should the reviewer start?
service_adapter.py
Any background context?
This resolves a failure to provision a Neutron LB on an IPv6 subnet. In the test scenario, the LB is placed on a shared IPv6 subnet while the backends are on an IPv4 tenant network.