Skip to content

Change Channel ID not known log message level #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change Channel ID not known log message level #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/request_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,11 @@ func (c *Connection) msgCallback(msgID uint16, data []byte) {
l.Debugf("Unable to decode message: %v", err)
}
}
l.Errorf("Channel ID not known, ignoring the message: %T %+v", msg, msg)
// This can happen when a stream was closed explicitly before the last message received.
// It's expected and not an error.
if log.Level >= logrus.DebugLevel {
Copy link
Member

@ondrej-fabry ondrej-fabry Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have included the part above that does decoding as that is actually what can have performance hit.

l.Debugf("Channel ID not known, ignoring the message: %T %+v", msg, msg)
}
return
}

Expand Down