feat: enable compatibility check for stream #322
+34
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlado Lavor <vlado.lavor@gmail.com>
Member
|
Moving the compatibility check into stream is incorrect and ineffective.. the check only uses the local message table loaded during connection/socket initialization; the stream (and underlying channel) is not used during the compatibility check at all. It would be better to put it to the Connection. |
Signed-off-by: Vlado Lavor <vlado.lavor@gmail.com>
Signed-off-by: Vlado Lavor <vlado.lavor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to do the compatibility check using
Stream. The user has to fall back to (already deprecated)Channeland then callCompatibilityCheckafterwards. Opening and closing a new channel is unnecessary overhead.The change exposes the compatibility check to the Stream API and uses the underlying channel object instead.