Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed other docker files: test and gdb #1623

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

jicarretero
Copy link
Collaborator

Proposed changes

Changes in other Dockerfiles that breaks github actions. Using real repos instead of packages.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • [ X] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • [ X] I have read the CONTRIBUTING doc
  • [ X] I have signed the CLA
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • [ X] I have added necessary documentation (if appropriate)
  • [ X] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

Copy link

github-actions bot commented Jun 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@kzangeli kzangeli merged commit 63b517e into develop Jun 5, 2024
11 checks passed
@kzangeli kzangeli deleted the restructure-docker branch June 5, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants