Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bounty tools to utils/ folder #13

Open
flibitijibibo opened this issue Jun 16, 2018 · 4 comments
Open

Add bounty tools to utils/ folder #13

flibitijibibo opened this issue Jun 16, 2018 · 4 comments

Comments

@flibitijibibo
Copy link
Member

This one's for @JohanSmet and @lamarqua.

While working on 3D, filters, and reverb you guys came up with a bunch of good tools to test these features. Let's try and get those into the FAudio repo.

I added a utils/ folder that now hosts testparse and facttool, but more importantly I split up the UI stuff I wrote for facttool and put it in a "uicommon" folder. This folder does all the boring stuff like rendering/input and ImGui interop, so you don't have to use the ImGui example code or other third-party bits, and it has a few declarations that tools can use:

https://github.com/flibitijibibo/FACT/blob/master/utils/uicommon/FAudioUI_main.c#L48

So you define those parts in your tool somewhere and then it should Just Work without any window/UI setup on your part; here's facttool as an example:

https://github.com/flibitijibibo/FACT/blob/master/utils/facttool/facttool.cpp

Pretty easy to use I hope! And of course if it's just a console-only program that just prints stuff, you can ignore this.

For now we're only going to add tools to the Makefile, since we're probably going to get into C/C++ features that VS2010 doesn't like, and right now I don't really care about that target for tests... MinGW works just fine for these. That's also pretty quick, since I'm just adding them as separate uberbuilds:

https://github.com/flibitijibibo/FACT/blob/master/Makefile#L68

We'll do VS2010 later on, since some of these tools do have the option to use XAudio2 alongside FAudio and that can be really useful. But that's busy work I can do later!

@JohanSmet
Copy link
Contributor

I created a PR (#14) that adds both the filter and reverb tools.

@flibitijibibo
Copy link
Member Author

Excellent, just merged those in. Just need the 3D stuff and I can close this; it’s not mission-critical so no rush!

@flibitijibibo
Copy link
Member Author

Since filing this issue a tests/ folder has been added:

https://github.com/FNA-XNA/FAudio/tree/master/tests

So Adrien’s work may fit better in this category. Would be great to have X3DAudio tests alongside the XAudio2 tests!

@lamarqua
Copy link
Contributor

lamarqua commented Dec 8, 2018

I'm gonna be on vacation soon and will get on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants