Added test and anchor properties fix #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jugen
added a commit
that referenced
this pull request
Nov 26, 2019
|
This PR was reverted in favor of a better solution in PR #877 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #874 anchor properties not updating correctly if they have listeners attached.
The problem seems to come down to the
internalStartedByAnchorBoolean property not firing on each invocation ofsetValue, but only when the actual value held changes.The most non intrusive and safest fix, I feel, is to just toggle the Boolean property when needed in order to fire any relevant change listeners.