Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards compatibility issue with Mixin 0.8.7's constructor descriptor targeting fix #152

Closed
KingContaria opened this issue Jul 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@KingContaria
Copy link

Hi,
before updating to fabricloader 0.16.0 i had to use slices to target different constructors of the same type.
While simply removing the slices and bumping loader dependency works, it seems the backwards compatibility has some issue:
Updating only the fabricloader in gradle.properties (and not bumping dependency) resulted in a crash when using the slices that previously worked in loader 0.15.7.

Old Mixin with Slices: https://github.com/KingContaria/StandardSettings/blob/c274c8688943200761c9634cb862dd6995239e35/src/main/java/me/contaria/standardsettings/mixin/fix/GameOptionsMixin.java

  • works on 0.15.7
  • crashes on 0.16.0, with dependency "fabricloader": ">=0.15.0"

Crash Stacktrace

@modmuss50 modmuss50 added the bug Something isn't working label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants