-
Notifications
You must be signed in to change notification settings - Fork 5
Rcpp string support #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
also can you please add some documentation (either in the package or on the wiki) about what steps need to be done to add a new supported data type? it looks like there are four parts of the code which need to be edited? Is there any way to reduce that number, to simplify addition of new data types? I'm thinking of some R list data structure which can be read to obtain all of the info necessary. |
|
@tdhock The
With #9 I changed the
|
|
Before I add the documentation, I wanted to ask you whether method is better for adding documentation within a package. |
|
A vignette is good especially if there are code examples where you want to show the output. |
|
@tdhock In the wiki, I've published a guide on how to add a new datatype to RcppDeepState. As you suggested, I included a link to the wiki in the readme file. |
|
these wiki page docs https://github.com/FabrizioSandri/RcppDeepState/wiki/Add-a-new-datatype-to-RcppDeepState look great thanks! |
With this pull request, the
Rcpp::Stringdatatype has been added to RcppDeepState. Now it is possible to analyze functions that take an argument of typeRcpp::String.A detailed description of the motivation behind this pull request can be found in the Issue #10.
Fixes #10