Introduce the script to ease the dev-build #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script spack_dev-build.sh eases the build of dev package using dev-build mode of spack. The script takes the spack find command output and forms the list of installed packages to be fed to the spack dev-build command.
|
Works like a charm for me. Thanks! |
|
Just tested it but got the following error: . ./spack_dev-build.sh ../../../FairRoot/dev/source fairroot mybuild+sim+examples while trying to concretize the partial spec: git requires pcre variant +jit, but spec asked for ~jit |
|
@TobiasStockmanns have you activated the environment before calling the script? |
|
Added protection against calling outside of spack env activate. |
|
Now I have it activated and the compilation started. Unfortunately it crashes with many a linker error to fair:Logger: |
|
Do you have a reasonably new FairRoot dev? |
It somehow mixes two different FairMQ versions - that is not good. |
|
No change with a new version of FairRoot: |
|
I am using "spack find" output for the list of packages. Did you try from to run the command from the clean shell and spack activate? This is certainly worrying that spack is trying to use different fairmqs.... |
|
I am using a clean shell but with SIMPATH and FAIRROOTPATH set and I run Here comes |
|
OK. So there comes a potential problem. I have decided to only use the "Root specs" part of the "spack find" output. I did it, because MY spack find output matches exactly the dev-build command from the fairsoft README instructions. For me the output looks: Checking, your env is probably env/dev/sim_threads.yaml, which has smaller number of specs, than our other env definitions. |
|
It may be worth a try to implement the proposed helper script as a spack extension written in python. That way, we can properly inspect and filter the environment and fairroot dependencies. |
|
After removing |
|
Great Tobias! Maybe the problem were then caused by the first unsuccessful tries. After doing it already few times, I usually delete this directory before starting the dev-build. The other problem is that I did not yet find a way to re'make' your spack-build. |
ChristianTackeGSI
requested changes
Jun 18, 2020
spack_dev-build.sh
Outdated
| return | ||
| fi | ||
|
|
||
| deps=$(spack find | sed -n '/Root/,/installed/p' | grep -v "Root specs" | grep -v ^$2@ | grep -v "installed packages" | sed 's/ //' | sed -e /^$/d | awk '{printf " ^%s",$0} END {print ""}'); |
There was a problem hiding this comment.
I am trying to come up with a little spack python to do that…
|
Here is a small python script, that does the same as the sed, awk, grep.
#! /usr/bin/python3
import sys
from argparse import ArgumentParser
from spack.environment import find_environment
def get_parser():
parser = ArgumentParser()
parser.add_argument("packagename")
return parser
def main():
parser = get_parser()
args = parser.parse_args()
env = find_environment(args)
if env is None:
sys.stderr.write("No environment\n")
sys.exit(1)
reslist = []
for spec in env.user_specs:
s = str(spec)
if s.startswith(args.packagename + '@'):
reslist.insert(0, s)
else:
reslist.append("^" + s)
print(" ".join(reslist))
if __name__ == '__main__':
main() |
|
It's OK with me, if you prefer python. |
|
Well, python let's us access the data structures of spack directly, without having to adapt to their output format. That's why I considered to rewrite the "prepare part of the commandline" part in python. My idea was to rewrite the That said, I am happy with everything that works for the people actually needing this! Yes, let's talk on Monday, or we can schedule something ad-doc using jitsi. P.S.: I have looked a bit into spack/spack#15256 (left a review), and that definitely looks like a good direction, but that still needs a bit of time. So it's good for us to have something going here first. |
Move both scripts to tools/. Add the possibility to run the script with 1 or 3 parameters.
karabowi
force-pushed
the
dev_build_script
branch
from
ee1ee67
to
508a54f
Compare
ChristianTackeGSI
approved these changes
Jun 22, 2020
This was referenced Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script spack_dev-build.sh eases the build
of dev package using dev-build mode of spack.
The script takes the spack find command output
and forms the list of installed packages
to be fed to the spack dev-build command.