Cleanup group Selector #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched to using flexbox. Removed hardcoded, top padding meant to center text Merged two sets of StyledComponents that were very similar Merge with clean up
Clean up avatar
Paragraph elements seem to get a lot of useragent style sheets applied and they are unnecessary. sdf
| font-size: 13px; | ||
| color: #585250; | ||
| white-space: nowrap; | ||
| width: ${props => props.size}px; |
There was a problem hiding this comment.
Is the width and height being overridden anywhere? Or is this old code?
There was a problem hiding this comment.
|
There are some issues with scrollbar fading in Firefox: |
|
In Group Selector without Groups: When mousing over Create, the button does not change state and appears to be unclickable. |
|
The two bugs you mentioned are present in the current version. Could I address those in a future PR? (i.e. not have them block this one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a number of fixes:
One is it removed some duplicated code and switched from using float and hardcoded padding to center things to using flex box.
Also, if removed some styles that were being set directly on components instead of using styled components.
Lastly, making a complicated component that works on everyone's web page is hard. 'p' elements were used in this component and were getting useragent styles with margins such that it looked nice in the catalog, but could look bad elsewhere. Switching to divs works around this and seems better since the 'p' elements weren't really being used for paragraphs of text.
@dustinsoftware