Improve close logic for backdrop #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change breaks closing the modal on iOS.. |
|
@dustinsoftware thats unfortunate. So iOS gets the onClick but not the mouseDown/ups? Think there are touchDown🏈/Ups that I could use? Currently it is pretty easy to close the modals on accident.. |
If you were to: mouseDown in a child, followed by dragging your mouse out of the child and a mouseUp in the background, you would receive an onClick and the target would be the backdrop. Then the current code would close the backdrop. This is not good when dragging a scrollbar as it is very easy to be dragging with the mouse down and release within the backdrop, causing accidentally closing. This also effects touchEvents too. Replace what was said above with touchStart/End instead of mouseDown/Up
JordanSjodinFaithlife
force-pushed
the
backdrop-fix
branch
from
c38230a
to
a9601f6
Compare
|
@dustinsoftware updated, and tested on a real iPhone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you were to:
mouseDownin a child, followed by dragging your mouse out of the child and amouseUpin the background, you would receive anonClickand the target would be the backdrop. Then the current code would close the modal. This is not good when dragging a scrollbar as it is very easy to be dragging with the mouse down and release within the backdrop, causing accidentally closing.This also effects touchEvents too. Replace what was said above with
touchStart/Endinstead ofmouseDown/Upold message
UsingonClick, amouseDownin a child , then dragging your mouse, and amouseUpin the background causesonClickto be called, and thetargetis the backdrop, thus it closes. This is no good when dragging a scrollbar as it is very easy to be dragging with the mouse down and then release while over the backdrop.