Create styled radio button #64
Conversation
|
Version updates need to be done outside the PR Also, alignment seems off: |
|
Should this be flashing white like this? Safari on Mac 10.13 |
|
@JordanSjodinFaithlife That does seem to also happen on Checkbox (which I copied), I'll see if I can't figure out what's causing it. |
| @@ -22,6 +22,10 @@ export const CheckboxContainer = styled.button` | |||
| min-height: 16px; | |||
| background: transparent; | |||
|
|
|||
| &:active { | |||
| color: buttontext; | |||
There was a problem hiding this comment.
This is my solution to the "white flash" that Safari has for these. By default Safari applies "activebuttontext" color to buttons with the ":active" pseudo-class. I'm not convinced this is the best idea, however because we're now enforcing a "buttontext" color on these controls. This makes one additional step to coloring the text of these elements, though it's arguably more discoverable than the Safari thing because it will act the same in all browsers.
There was a problem hiding this comment.
@dustinsoftware is there a more "styled-ui" way of doing this, in your opinion?
No description provided.