Add date range picker options #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imundy
force-pushed
the
date-range-picker
branch
from
335f29a
to
744b846
Compare
Imundy
commented
Nov 28, 2018
| setSelectedDate: PropTypes.func.isRequired, | ||
| /** specifies that the component should function as a date range picker */ | ||
| asDateRangePicker: PropTypes.bool, |
There was a problem hiding this comment.
@dustinsoftware here are the API changes I mentioned. It should behave the same if the new props are left out (so non-breaking).
|
Updated this with the date period picker as well. |
Imundy
force-pushed
the
date-range-picker
branch
from
a47a251
to
ccf4d27
Compare
|
|
||
| const DATE_FORMAT_STRING = 'M/d/yyyy'; | ||
|
|
||
| export class DatePeriodPicker extends PureComponent { |
There was a problem hiding this comment.
Missing a jsdoc comment describing this component and its functionality
| start: PropTypes.instanceOf(Date), | ||
| end: PropTypes.instanceOf(Date), | ||
| }), | ||
| /** Returns a daate when selected. If asDateRangePicker is true, it will return a date range object matching the selectedDateRange prop shape */ |
|
👍 Sounds good, once the beta packages are out I'll try to integrate it back into giving. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.